Extracted repo missing node_modules folder about frogbot

[FredrikLiindgren]

Hey @EyalDelarea,

You are correct in that I've not set installCommand in frogbot-config.yml.
However I've set the GitLab CI/CD variable JF_INSTALL_DEPS_CMD: npm i which I thought would be enough but I might be wrong.
I've done as much config as possible via GitLab CI/CD variables but added the frogbot-config.yml the frogbot commands were not working without it. Might be missing some other mandatory config in there.

My full frogbot-config.yml:

- params:
    git:
      repoName: demo-app
      branches:
        - main

Nice to hear about the about not needing to set installCommand!

[EyalDelarea]

For a quick fix you could add the following line to your config file:

  - params:
        git:
          repoName: demo-app
          branches:
            - main
        scan:
          projects:
            - installCommand: "npm i"

Or wait for the release.
Either way waiting to hear how it worked out for you !

[EyalDelarea]

Hey @FredrikLiindgren , that's great to hear!

We will definitely update the docs so it won't be missleading :)

Thank you for your feedback!

[FredrikLiindgren]

Hi @eyalbe4 - Any reason for instantly closing this? I'd be happy to provide further details if necessary.

Kind Regards,
Fredrik

[sverdlov93]

It was mistakenly closed @FredrikLiindgren
We are looking into it and will let you know very soon.

[FredrikLiindgren]

@sverdlov93 alright, thanks for taking a look!

[EyalDelarea]

Hey @FredrikLiindgren,

Thank you for using Frogbot!

The cause of the the missing node_modules folder could be because the installCommand inside
your frogbot-config.yml (line 30) file is not set.
Could you provide us with your configuration ?

And i'm just about to release a new version of Frogbot which will not require to set the installCommand for npm packages anymore, so hope you won't encounter this problem in the future.

[FredrikLiindgren]

Hi that worked great,

However this makes me think the docs about that is quite missleading as this

    # [Mandatory if the two conditions below are met]
    # 1. The project uses npm, yarn 2, NuGet or .NET to download its dependencies
    # 2. The `installCommand` variable isn't set in your frogbot-config.yml file.
    #
    # The command that installs the project dependencies (e.g "npm i", "nuget restore" or "dotnet restore")
    JF_INSTALL_DEPS_CMD: ""

Makes me think I do not have to define the installCommand in the frogbot-config.yml file if I've defined JF_INSTALL_DEPS_CMD :)

[FredrikLiindgren]

Great @EyalDelarea - Thanks for your helpful & timely responses!