github.com/jfcg/sorty/v2.SortSlice: nosplit stack over 792 byte limit about sorty

[jfcg]

I have run into this problem myself. Here is the solution I've found:

• go test -c -o myTest
• VS Code > Run and Debug > create a launch.json file > "Go" from drop down menu > Go: Launch Package
• Inside .vscode/launch.json, update as "name": "My Test", "mode": "exec" and "program": "./myTest"
• You can give -test.run regex argument to ./myTest to run specific test(s)
• Run and Debug > Green play button will run/debug ./myTest

I dont really know why compiling the test exec first works.

Cheers..

[mariotoffia]

Thanks!! :)

[s0xzwasd]

Same issue in GoLand (2023.3.2) and Go 1.21.6 where you cannot change mode to exec.

Workaround is to use Attach to Process with time.Sleep() but it's requires additional setup and not very straightforward.

package somepackage

import (
	"github.com/mariotoffia/goannoy/builder"
	"testing"
	"time"
)

func Test_IncludeGoAnnoy(t *testing.T) {
	builder := builder.Index[float32, uint32]().
		AngularDistance(255).
		UseMultiWorkerPolicy().
		MmapIndexAllocator().
		Build()
	time.Sleep(time.Second * 15) // set time
	builder.Close() // set breakpoint
}

• Set time, run test as usual (not debugging).
• Invoke Run | Attach to Process in the main menu.
• Select a test process (not go test or test2json)

@jfcg Could you please take a look? It seems that -gcflags all=-N -l + //go:nosplit directive causes this issue in 1.19.* and lower: golang/go#54291

golang/go#54291 (comment)

[jfcg]

Hi,
For sorty's core use case, removing stack check & preventing preemption (especially at leaf functions) are important for performance. So go:nosplit directives need to stay. There is a solution working for VSCode, so maybe you could consider

• adding "mode": "exec" launch configuration to GoLand IDE (mid to long term)
• vendoring sorty and removing some go:nosplits for getting past your debug compilation errors (short term)

Cheers..