Coder Social home page Coder Social logo

Comments (5)

TehMillhouse avatar TehMillhouse commented on August 22, 2024

grep for "HEATER_FAIL_". There are some basic sanity checks in place which you can test by, for instance, disconnecting the thermistor from your Hotend and turning on the heater cartridge. I don't know how exhaustive the checks are, but basic heater / thermistor failure seems to be caught.

EDIT: See also #172, so while the thermal runaway protection will prevent your house from burning down, it won't protect your hardware from destroying itself :\

from sailfish-mightyboardfirmware.

SaschaKP avatar SaschaKP commented on August 22, 2024

It only needs to add An abort print on the thermal shutdown case

from sailfish-mightyboardfirmware.

Halbelunge avatar Halbelunge commented on August 22, 2024

I had the same question for my device with sailfish. So I checked the program code.
This can be found in the Heater.hh and Heater.cc:

enum HeaterFailMode{
HEATER_FAIL_NONE = 0,
HEATER_FAIL_NOT_PLUGGED_IN = 0x02,
HEATER_FAIL_SOFTWARE_CUTOFF = 0x04,
HEATER_FAIL_NOT_HEATING = 0x08,
HEATER_FAIL_DROPPING_TEMP = 0x10,
HEATER_FAIL_BAD_READS = 0x20
};

This is what is the interesting part: HEATER_FAIL_NOT_HEATING = 0x08,

Furthermore in the Heater.cc:

  // check that the heater is heating up after target is set
  if(!progressChecked){
       if(heatProgressTimer.hasElapsed()){
	    if(current_temperature < (startTemp + HEAT_PROGRESS_THRESHOLD )){
		 value_fail_count++;

		 if (value_fail_count > SENSOR_MAX_BAD_READINGS) {
		      fail_mode = HEATER_FAIL_NOT_HEATING;
		      fail();
		      return;
		 }
	    }
	    else
		 progressChecked = true;
       }

This seems to do exactly this check, what you mean with thermal runaway.

In my opinion, this can be closed.
Did you ever checked @rpavlik ?

from sailfish-mightyboardfirmware.

SaschaKP avatar SaschaKP commented on August 22, 2024

What they mean is that even if that code is run, it doesn't prevent the printer from continuing the print, even if the heater is shut down, this can cause some hardware damage, as the filament is continuosly pushed in. My code option was already done in my fork, as this tree is INACTIVE and abandoned.

from sailfish-mightyboardfirmware.

Halbelunge avatar Halbelunge commented on August 22, 2024

Ahh ok, I see.
But hey, at least it will not burn your house down, because of an open loop in the thermal regulation.

from sailfish-mightyboardfirmware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.