Wrong syntax higlighting parenthesis (C++) about seti-syntax

[jesseweed]

I don't write C++ so haven't been able to validate, but I have checked several other languages and can't seem to repro the bug. Are you still seeing this issue?

[0xShammah]

Yes, I have updated the theme to the latest version and am using Atom v0.119. The issue is still there, and it happens even on a clean Atom installation with the theme. It also happens only with this theme.

[SeriousM]

@Shammah - maybe you post a gist of your wrong-highlighted code?

[0xShammah]

Well, the image really shows what goes wrong already.
The gist was made anyway, and can be found at https://gist.github.com/Shammah/4ba82a272069b84366c8

[Pyr0x1]

Same problem here, I noticed it happens only with built-in functions or statements, like "if", "for", "printf", "free", etc... and only if you leave a space before the parenthesis. Maybe this could be of some help.

[sir-mulan]

Any progress on this? The issue is still present.

I am not familiar with this modern websy stuff but it might be helpful to point out that according to the dev tools, when the bracket is white (therefore right after the keyword – if in this case), it's a plain character inside class="meta block c" while if it's blue (there is a space before it), the space and the bracket are additionally inside class="meta initialization c" and the bracket itself additionally inside class="punctuation definition parameters c".

I don't know which one is responsible for the colour but it shouldn't be that hard to make an exception, right?

EDIT: It's .punctuation.definition.parameters. Now let's figure out how to fix it.

Lines 296–302 in index.less:

// QUOTES
&.string,
&.variable,
&.parameters,
&.array {
  color: @string;
}

It's just a logical assumption, but a dirty fix could be something like &.parameters.c {color: @code-font-color;}, right? However, is this not an issue with the parser given that the classes of the same character differ depending on the space?

[jameslzhu]

I managed to track down the exact problem. I've submitted a pull request to the language-c repo here:
atom/language-c#62

tl;dr it's a stray question mark causing the pattern ( to be matched (whitespace and parenthesis).

[sir-mulan]

@jzhu98 Well done, I've glanced over some files and it doesn't appear to break anything. Also fixes the same issue in Sublime. Thanks!