Coder Social home page Coder Social logo

Comments (12)

karloluis avatar karloluis commented on August 16, 2024

True. Better contrast would be very much appreciated. if the owner tells me where I can find it I'll fork it and fix it with a lighter grey maybe. Submit colors that you think might work as well.

from seti-syntax.

asantos3 avatar asantos3 commented on August 16, 2024

You can easily find it, after you doing the search thingy, open the dev tools and find a div with a "highlights underlayer" class and there should be a child div per found result.

You should find this:

.editor .find-result .region {
  background-color: transparent;
  border-radius: 2px;
  border: 1px solid #888888;
  box-sizing: border-box;
}

Due to atom/atom#4165 you will need to add : host like .editor .find-result .region, :host .find-result .region { ... }

from seti-syntax.

karloluis avatar karloluis commented on August 16, 2024

Can you please make a gift of what you mean. Thank you.

from seti-syntax.

asantos3 avatar asantos3 commented on August 16, 2024

Sure. Sorry about the quality but here you go:

atom gif

from seti-syntax.

karloluis avatar karloluis commented on August 16, 2024

Well yeah. I see what you mean but one might consider that way to troublesome if it where to find minute changes. It is too much trouble and changing the base color of the theme would help a lot. Making contrasts is certainly a better choice for efficient use.

from seti-syntax.

starstatus avatar starstatus commented on August 16, 2024

If we have to do that for every find result, it'll be annoying.

from seti-syntax.

starstatus avatar starstatus commented on August 16, 2024

Changing the color to bright yellow or red would help a lot.

from seti-syntax.

asantos3 avatar asantos3 commented on August 16, 2024

That's how you debug it and find the css class, you could change it on your stylesheet file though.

from seti-syntax.

starstatus avatar starstatus commented on August 16, 2024

Good! Thanks

from seti-syntax.

jesseweed avatar jesseweed commented on August 16, 2024

I agree, the highlight here is way too subtle! I plan to modify in the next update, should be this week sometime.

from seti-syntax.

jesseweed avatar jesseweed commented on August 16, 2024

Updated highlight colors in latest version. I think it's better but still not perfect. I was having a little trouble tracking down all the exact styles with the new shadow dom (I was able to get the border, but not the background yet on search). I don't have time to dig into it any deeper right now, so updating with this for now, may try and come back to it later.

Anybody else should also feel free to take a stab at it.

from seti-syntax.

starstatus avatar starstatus commented on August 16, 2024

Thanks!

from seti-syntax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.