subtract instance methods about date-utils

[lancecarlson]

Looking at the yesterday implementation, it looks like there is certainly support for it but there is no documentation for supplying .add with negative values. Maybe add should be renamed or subtract methods added with the negative behavior?

[JerrySievert]

renaming add would be a breaking change, but yes, there is (undocumented) support for negative numbers.

[lancecarlson]

Perhaps it should be documented ? If not, maybe have subtract functions?

[JerrySievert]

Agreed! I'll try to get it documented shortly. As an aside, documentation related pull requests are always welcome! :)

[lancecarlson]

Well, I would've but I also wanted to make sure you would rather have it documented then have additional methods. If I have time tomorrow (and you haven't documented it already) I will submit a pull request! =D

[JerrySievert]

that would be awesome! the library is growing fairly large as-is, which means either a) a ton of refactoring, or b) keep the number of methods low.

a refactoring with a ton more documentation would be nice, which would allow for more cleanliness and still allow for a more full api.

[bebraw]

If you decide to refactor it (v2?), find a common name that works for addition and subtraction. It would be nice to have a non-mutating way to deal with dates by the way? Consider the following example:

var now = new Date();
var twoMonthsAgo = now.modify({months: -2});
var duration = twoMonthsAgo.to(now); // {months: -2}

duration output depends on order. It is also possible to pass the output to modify so the API is pluggable this way.

Maybe my use cases are different than others and there are likely reasons for the mutating API (OOP after all :) ). I would find this sort of thing very cool, though.

[JerrySievert]

v2. wow. there should probably be an issue that can help hash out goals for v2.

[bebraw]

@JerrySievert Can you start one?

[JerrySievert]

remove added, closing this!