Comments (7)
Have you considered using a copy of the key instead of a pointer? Generally keys are pretty small, but you would need K: Clone
which may be a breaking change.
from lru-rs.
Ah nevermind, this would work poorly if the key is something like a String
.
Regarding the hash table, I don't think hashbrown is a good fit, but you may be interested in Amanieu/intrusive-rs#37.
from lru-rs.
I don't think hashbrown is a good fit
It'd be nice to benefit from hashbrown's optimizations. It seems like the only missing piece here is the ability for the caller to control the rehashing operation. In particular, it would be necessary for this lib to remove elements from the old table and insert them into the new one in LRU list order, constructing the correct chain as it goes.
That could be accomplished by something as simple as impl RawTable<T> { fn resize(&mut self, n: usize, rehash: impl Fn(&mut [MaybeUninit<T>], &mut [MaybeUninit<T>])) }
. Is anything like that completely out of the question?
from lru-rs.
On review, I think this could be accomplished with the existing interface by constructing the LRU list from bucket indices rather than raw pointers. As a bonus, I think this would allow removing nearly all of the unsafe
from this crate, including the dicey uninitialized stuff.
from lru-rs.
@jeromefroe, would you be interested in a PR to replace the use of pointers with bucket indices, and thereby remove all the boxing?
from lru-rs.
@Ralith definitely, would be more than happy to review it.
from lru-rs.
Hmm, bucket indexes still need to be rewritten on rehash. This would be really easy if hashbrown exposed a hook to rewrite entries on rehash, and otherwise seems infeasible.
from lru-rs.
Related Issues (20)
- RwLock read() usage HOT 1
- Consider replacing HashMap with HashSet HOT 1
- Use after free bug in lru crate HOT 2
- Am I able to cache egui? HOT 1
- Lifetime fix is missing from the changelog for 0.7.4 HOT 2
- Full check leak report reachable bytes HOT 1
- Method that removes an entry corresponding to the key and returns both the key and the value
- Failed to build with feature "nightly" HOT 1
- Allow more liberal closure for `get_or_insert` HOT 2
- Could we have a new version with the updated `hashbrown` (and maybe others) dependency ? HOT 2
- Support const new
- Limit by memory instead of number of items HOT 4
- Cache size 0 / Disable Cache HOT 3
- Cache key may not work HOT 5
- Debug not defined for custom BuildHasher
- Missing lifetime specifier in try_get_or_insert_mut? HOT 1
- Add `get_key_value` method
- Proposal to Integrate SIEVE Eviction Algorithm HOT 12
- Implement Clone on LruCache HOT 5
- Clone is only implemented for the default hasher HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lru-rs.