Coder Social home page Coder Social logo

Comments (88)

posixx avatar posixx commented on August 26, 2024 1

No I don’t. Will try tomorrow as I’m in bed now, maybe I need to restart ha

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024 1

Fantastic, this is exactly how we get the most acurate results. Great work Jeroen!

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

That's fair. By the way, why are you using this component anyway? Your image shows that you already have the ET value... So all the calculations could be skipped...

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Because i didn't know :-). Also the automatic bucket isn't part of the weatherstation, so skipping a day isn't possible..

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

right, ok, I get that. I will see if I can make the requested change and maybe even just use the ET value provided by the weather station. Out of curiosity, could you track the calculations and the ET value reported by the weather station to see if they compare?

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

yes. will do. At this moment hourly ET value: 5.454794381670322, ET of weatherstation: 5.207 so that looks comparable...

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

BTW here you can find info of how the Davis system is calculating ET: https://www.davisinstruments.com/product_documents/weather/app_notes/AN_28-derived-weather-variables.pdf

It's a lot of acabadabra to me:-)

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

I saw the ET value of the Davis station resets to 0 at 12AM. Right now the ET value of davis = 1.803; on hourly sensors 5.888761835879981. So i guess the Davis ET value will be daily based, i will compare daily value tonight at 23h

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

you can now use a sensor for solar radiation or even skip all calculations and just provide a sensor for ET. I marked it as a pre-release, please test and confirm it works in both scenarios (scenario 1: sensor for et, scenario 2: no sensor for et but sensor for solar radiation and others). I don't have the sensors so I rely on you @posixx!

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Great work. I will keep old version active until tomorrow as it will irrigate this night, and setup the integration tomorrow using ET sensor and solar as i use 2 integrations for 2 zones.

At this moment daily bucket calculation = 5.058734214281175, ET value of Davis weatherstation = 6.223

Lets see how it goes tomorrow.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

I don't know why but HASmartirrigation component is not showing v0.0.55 as new version. It still lists v0.0.50b as latest..

EDIT: v0.0.50b still marked as latest release, v0.0.55 marked as pre-release. Can you fix that?

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

No, I choose pre-release on purpose as I had no good way testing this end to end. Enable the install of beta versions in HACS or just download and overwrite the files manually, please. Again, I am depending on you to test this.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Ah ok. I copied over the new version. 1st issue (i think): when selecting an ET sensor, i shouldn't have to insert reference values for each month? I get this wizard step after inserting the ET sensor..

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

After adding both integrations to HA:

2020-06-25 16:11:18 WARNING (MainThread) [custom_components.smart_irrigation] sources: {'use_owm_precipitation': True, 'use_owm_temperature': True, 'use_owm_min_temperature': True, 'use_owm_max_temperature': True, 'use_owm_dewpoint': True, 'use_owm_pressure': True, 'use_owm_humidity': True, 'use_owm_windspeed': True, 'calculate_solar_radiation': True, 'calculate_ET_value': False}
2020-06-25 16:11:18 WARNING (MainThread) [custom_components.smart_irrigation] sensors: {'sensor_et': 'sensor.davis_verdamping'}
2020-06-25 16:12:03 ERROR (MainThread) [frontend.js.latest.202006033] http://homeassistant:8123/hacsfiles/circle-sensor-card/circle-sensor-card.js:76:79 Uncaught TypeError: Cannot read property 'state' of undefined
2020-06-25 16:14:49 WARNING (MainThread) [custom_components.smart_irrigation] sources: {'use_owm_precipitation': False, 'use_owm_temperature': False, 'use_owm_min_temperature': False, 'use_owm_max_temperature': False, 'use_owm_dewpoint': False, 'use_owm_pressure': False, 'use_owm_humidity': False, 'use_owm_windspeed': False}
2020-06-25 16:14:49 WARNING (MainThread) [custom_components.smart_irrigation] sensors: {'sensor_precipitation': 'sensor.davis_regenhoveelheid_dag', 'sensor_temperature': 'sensor.davis_buitentemperatuur', 'sensor_min_temperature': 'sensor.davis_laagste_temperatuur', 'sensor_max_temperature': 'sensor.davis_hoogste_temperatuur', 'sensor_dewpoint': 'sensor.davis_dauwpunt', 'sensor_pressure': 'sensor.davis_barometer', 'sensor_humidity': 'sensor.davis_luchtvochtigheid', 'sensor_windspeed': 'sensor.davis_windsnelheid_gemiddeld', 'sensor_solar_radiation': 'sensor.davis_zonnestraling'}

sensor values voortuin (running ET sensor:
image

sensor values achtertuin (running all weatherstation sensors):
image

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

Hmm, I think you're right, reference ETs should not be required when setting the ET sensor . Or maybe it is. I have to think about that. Thanks. I see no other obvious issues, correct? Please let it run and see if the calculations make sense. Many thanks again

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

will look at the values tonight at 23:55. I set this right before ET sensor is reset to 0.

Keep you posted.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Additional info: after adding the ET value as sensor to HA it behaves as calculated ET:

image

Looks good!

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

I have looked into it, you still need to provide the reference ET values since we need a way to calculate the base schedule index, which is based on the max(reference_et). base schedule index is used for water budget and adjusted run time. So I think this is correct.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Jeroen,

Hourly value at 23:50 tonight:

image

These values are comparable.

Daily sensors after 23:55 (time which daily value is calculated:

image

the voortuin is using ET sensor, so expected to see same ET vvalue as realtime weatherstation value:

image

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Hmm strang thing i see:

image

Hourly adjusted runtime on achtertuin is not updating? Last updated 7 hours ago.

Using ET sensor is updating fine, beck to 0 at 0:00 which is expected:

image

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

Hmm, that is weird, did you see anything in the logs that points to why this update did not happen?

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Nope no logged messages.. let’s see what the values have done in the morning..

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

Can you enable info level logging for this component? It will log a lot of info, so be prepared, but might help to explain what is going on.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Hmm then i will add it to my dev HASS. How to manually install the integration? I added the smartirrigation folder to custom_components but i cannot select it from integration setup..

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Found it, browser cache. Here is the log:

2020-06-26 11:12:30 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for smart_irrigation which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant.
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation]

Smart Irrigation
Version: 0.0.55
If you have any issues with this you need to open an issue here:
https://github.com/jeroenterheerdt/HASmartIrrigation/issues

2020-06-26 11:12:31 WARNING (MainThread) [custom_components.smart_irrigation] sources: {'use_owm_dewpoint': False, 'use_owm_humidity': False, 'use_owm_max_temperature': False, 'use_owm_min_temperature': False, 'use_owm_precipitation': False, 'use_owm_pressure': False, 'use_owm_temperature': False, 'use_owm_windspeed': False}
2020-06-26 11:12:31 WARNING (MainThread) [custom_components.smart_irrigation] sensors: {'sensor_dewpoint': 'sensor.davis_dauwpunt', 'sensor_humidity': 'sensor.davis_luchtvochtigheid', 'sensor_max_temperature': 'sensor.davis_hoogste_temperatuur', 'sensor_min_temperature': 'sensor.davis_laagste_temperatuur', 'sensor_precipitation': 'sensor.davis_regenhoveelheid_dag', 'sensor_pressure': 'sensor.davis_barometer', 'sensor_solar_radiation': 'sensor.davis_zonnestraling', 'sensor_temperature': 'sensor.davis_buitentemperatuur', 'sensor_windspeed': 'sensor.davis_windsnelheid_gemiddeld'}
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation] Auto refresh is enabled. Scheduling for 23:55.
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation] Initial update scheduled for 2020-06-26 11:17:31.664927+02:00
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation] Updating Smart Irrigation Data
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] sensor init for current_adjusted_run_time. bucket_delta=0
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] sensor init for adjusted_run_time. bucket=0
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation] registering: type: Base Schedule Index, entity: sensor.smart_irrigation_base_schedule_index
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Base Schedule Index state: 686.0, attributes: {'area': '26.0 m2', 'auto_refresh': True, 'auto_refresh_time': '23:55', 'base_schedule_index_minutes': '11.43 min', 'coastal': False, 'estimate_solrad_from_temp': True, 'flow': '7.845 l', 'friendly_name': 'Base Schedule Index', 'icon': 'mdi:sprinkler', 'initial_update_delay': '300 s', 'number_of_sprinklers': 1.0, 'peak_evapotranspiration': '3.45 mm', 'precipitation_rate': '18.103846153846153 mm/hour', 'reference_evapotranspiration': '[0.46, 0.73, 1.29, 2.09, 3.01, 3.29, 3.45, 3.02, 1.87, 1.1, 0.57, 0.42] mm', 'throughput': '7.845 liter/minute', 'unit_of_measurement': 's'}
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Base Schedule Index
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Base Schedule Index
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation] registering: type: Hourly Adjusted Run Time, entity: sensor.smart_irrigation_hourly_adjusted_run_time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Hourly Adjusted Run Time state: 0, attributes: {'adjusted_run_time_minutes': '0.0 min', 'evapotranspiration': '0.0 mm', 'friendly_name': 'Hourly Adjusted Run Time', 'icon': 'mdi:sprinkler', 'netto_precipitation': '0.0 mm', 'precipitation': '0.0 mm', 'rain': '0.0 mm', 'snow': '0.0 mm', 'unit_of_measurement': 's', 'water_budget': '0.0 %'}
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Hourly Adjusted Run Time, attribute: evapotranspiration, attribute_value: 0.0 mm, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Hourly Adjusted Run Time, attribute: netto_precipitation, attribute_value: 0.0 mm, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_to_hass restoring state, setting netto precipitation / bucket_delta to: 0.0
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Hourly Adjusted Run Time, attribute: precipitation, attribute_value: 0.0 mm, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Hourly Adjusted Run Time, attribute: rain, attribute_value: 0.0 mm, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Hourly Adjusted Run Time, attribute: snow, attribute_value: 0.0 mm, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Hourly Adjusted Run Time, attribute: water_budget, attribute_value: 0.0 %, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Hourly Adjusted Run Time, attribute: adjusted_run_time_minutes, attribute_value: 0.0 min, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Hourly Adjusted Run Time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_dewpoint, sensor_setting: sensor_dewpoint, sensor_name: sensor.davis_dauwpunt, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_humidity, sensor_setting: sensor_humidity, sensor_name: sensor.davis_luchtvochtigheid, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_max_temperature, sensor_setting: sensor_max_temperature, sensor_name: sensor.davis_hoogste_temperatuur, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_min_temperature, sensor_setting: sensor_min_temperature, sensor_name: sensor.davis_laagste_temperatuur, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_precipitation, sensor_setting: sensor_precipitation, sensor_name: sensor.davis_regenhoveelheid_dag, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_pressure, sensor_setting: sensor_pressure, sensor_name: sensor.davis_barometer, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_temperature, sensor_setting: sensor_temperature, sensor_name: sensor.davis_buitentemperatuur, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_windspeed, sensor_setting: sensor_windspeed, sensor_name: sensor.davis_windsnelheid_gemiddeld, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] rain: 0.0, snow: 0.0
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] skipped calculating evapotranspiration, got the following value from a sensor: 0.0
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Hourly Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: 9000, change percentage: 1.0, type: Hourly Adjusted Run Time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state: just updated hourly_bucket_list: [0.0]
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Hourly Adjusted Run Time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_dewpoint, sensor_setting: sensor_dewpoint, sensor_name: sensor.davis_dauwpunt, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_humidity, sensor_setting: sensor_humidity, sensor_name: sensor.davis_luchtvochtigheid, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_max_temperature, sensor_setting: sensor_max_temperature, sensor_name: sensor.davis_hoogste_temperatuur, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_min_temperature, sensor_setting: sensor_min_temperature, sensor_name: sensor.davis_laagste_temperatuur, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_precipitation, sensor_setting: sensor_precipitation, sensor_name: sensor.davis_regenhoveelheid_dag, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_pressure, sensor_setting: sensor_pressure, sensor_name: sensor.davis_barometer, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_temperature, sensor_setting: sensor_temperature, sensor_name: sensor.davis_buitentemperatuur, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_windspeed, sensor_setting: sensor_windspeed, sensor_name: sensor.davis_windsnelheid_gemiddeld, sensor_state: None
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] rain: 0, snow: 0
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] skipped calculating evapotranspiration, got the following value from a sensor: 0.0
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Hourly Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: 9000, change percentage: 1.0, type: Hourly Adjusted Run Time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state: just updated hourly_bucket_list: [0.0, 0.0]
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation] registering: type: Daily Adjusted Run Time, entity: sensor.smart_irrigation_daily_adjusted_run_time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Daily Adjusted Run Time state: 0, attributes: {'adjusted_run_time_minutes': '0.0 min', 'bucket': '0.0 mm', 'force_mode_duration': 0, 'force_mode_enabled': False, 'friendly_name': 'Daily Adjusted Run Time', 'icon': 'mdi:sprinkler', 'lead_time': '0 s', 'maximum_duration': '9000 s', 'unit_of_measurement': 's', 'water_budget': '0.0 %'}
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Daily Adjusted Run Time, attribute: water_budget, attribute_value: 0.0 %, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Daily Adjusted Run Time, attribute: bucket, attribute_value: 0.0 mm, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_to_hass restoring state, settting bucket to: 0.0
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Daily Adjusted Run Time, attribute: adjusted_run_time_minutes, attribute_value: 0.0 min, numeric_part: 0.0, show_units: True, a_val was str or contained ' ': True
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Daily Adjusted Run Time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Daily Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: 9000, change percentage: 1.0, type: Daily Adjusted Run Time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] calculating wb and art for daily adjusted run time, result: {'wb': 0, 'art': 0}
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Daily Adjusted Run Time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Daily Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: 9000, change percentage: 1.0, type: Daily Adjusted Run Time
2020-06-26 11:12:31 INFO (MainThread) [custom_components.smart_irrigation.sensor] calculating wb and art for daily adjusted run time, result: {'wb': 0, 'art': 0}
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation] Initial update triggered - calling calculate hourly adjusted run time now.
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation] Calculate Hourly Adjusted Run Time service called, calculating now.
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation] Updating Smart Irrigation Data
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] _hourly_data_updated, calling update_state for type Hourly Adjusted Run Time
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state for type: Hourly Adjusted Run Time
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_dewpoint, sensor_setting: sensor_dewpoint, sensor_name: sensor.davis_dauwpunt, sensor_state: <state sensor.davis_dauwpunt=16.8; unit_of_measurement=°C, friendly_name=Davis Dauwpunt, icon=mdi:thermometer @ 2020-06-26T11:16:56.233600+02:00>
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state state value: 16.8
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_humidity, sensor_setting: sensor_humidity, sensor_name: sensor.davis_luchtvochtigheid, sensor_state: <state sensor.davis_luchtvochtigheid=52; unit_of_measurement=%, friendly_name=Davis Luchtvochtigheid, icon=mdi:water-percent @ 2020-06-26T11:12:37.587615+02:00>
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state state value: 52
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_max_temperature, sensor_setting: sensor_max_temperature, sensor_name: sensor.davis_hoogste_temperatuur, sensor_state: <state sensor.davis_hoogste_temperatuur=27.8; unit_of_measurement=°C, friendly_name=Davis Hoogste Temperatuur, icon=mdi:weather-windy @ 2020-06-26T11:12:37.628639+02:00>
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state state value: 27.8
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_min_temperature, sensor_setting: sensor_min_temperature, sensor_name: sensor.davis_laagste_temperatuur, sensor_state: <state sensor.davis_laagste_temperatuur=18.3; unit_of_measurement=°C, friendly_name=Davis Laagste Temperatuur, icon=mdi:weather-windy @ 2020-06-26T11:12:37.629338+02:00>
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state state value: 18.3
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_precipitation, sensor_setting: sensor_precipitation, sensor_name: sensor.davis_regenhoveelheid_dag, sensor_state: <state sensor.davis_regenhoveelheid_dag=0.0; unit_of_measurement=mm, friendly_name=Davis Regenhoveelheid Dag, icon=mdi:weather-rainy @ 2020-06-26T11:12:37.588388+02:00>
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state state value: 0.0
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_pressure, sensor_setting: sensor_pressure, sensor_name: sensor.davis_barometer, sensor_state: <state sensor.davis_barometer=1011.0; unit_of_measurement=mbar, friendly_name=Davis Barometer, icon=mdi:gauge @ 2020-06-26T11:17:06.251640+02:00>
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state state value: 1011.0
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_temperature, sensor_setting: sensor_temperature, sensor_name: sensor.davis_buitentemperatuur, sensor_state: <state sensor.davis_buitentemperatuur=27.6; unit_of_measurement=°C, friendly_name=Davis Buitentemperatuur, icon=mdi:thermometer @ 2020-06-26T11:17:26.276583+02:00>
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state state value: 27.6
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_windspeed, sensor_setting: sensor_windspeed, sensor_name: sensor.davis_windsnelheid_gemiddeld, sensor_state: <state sensor.davis_windsnelheid_gemiddeld=4; unit_of_measurement=km/h, friendly_name=Davis Windsnelheid Gemiddeld, icon=mdi:weather-windy @ 2020-06-26T11:16:56.233385+02:00>
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state state value: 4
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] rain: 0.0, snow: 0.0
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] skipped calculating evapotranspiration, got the following value from a sensor: 0.0
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Hourly Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: 9000, change percentage: 1.0, type: Hourly Adjusted Run Time
2020-06-26 11:17:32 INFO (SyncWorker_2) [custom_components.smart_irrigation.sensor] update_state: just updated hourly_bucket_list: [0.0, 0.0, 0.0]
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Hourly Adjusted Run Time
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_dewpoint, sensor_setting: sensor_dewpoint, sensor_name: sensor.davis_dauwpunt, sensor_state: <state sensor.davis_dauwpunt=16.8; unit_of_measurement=°C, friendly_name=Davis Dauwpunt, icon=mdi:thermometer @ 2020-06-26T11:16:56.233600+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 16.8
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_humidity, sensor_setting: sensor_humidity, sensor_name: sensor.davis_luchtvochtigheid, sensor_state: <state sensor.davis_luchtvochtigheid=52; unit_of_measurement=%, friendly_name=Davis Luchtvochtigheid, icon=mdi:water-percent @ 2020-06-26T11:12:37.587615+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 52
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_max_temperature, sensor_setting: sensor_max_temperature, sensor_name: sensor.davis_hoogste_temperatuur, sensor_state: <state sensor.davis_hoogste_temperatuur=27.8; unit_of_measurement=°C, friendly_name=Davis Hoogste Temperatuur, icon=mdi:weather-windy @ 2020-06-26T11:12:37.628639+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 27.8
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_min_temperature, sensor_setting: sensor_min_temperature, sensor_name: sensor.davis_laagste_temperatuur, sensor_state: <state sensor.davis_laagste_temperatuur=18.3; unit_of_measurement=°C, friendly_name=Davis Laagste Temperatuur, icon=mdi:weather-windy @ 2020-06-26T11:12:37.629338+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 18.3
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_precipitation, sensor_setting: sensor_precipitation, sensor_name: sensor.davis_regenhoveelheid_dag, sensor_state: <state sensor.davis_regenhoveelheid_dag=0.0; unit_of_measurement=mm, friendly_name=Davis Regenhoveelheid Dag, icon=mdi:weather-rainy @ 2020-06-26T11:12:37.588388+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 0.0
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_pressure, sensor_setting: sensor_pressure, sensor_name: sensor.davis_barometer, sensor_state: <state sensor.davis_barometer=1011.0; unit_of_measurement=mbar, friendly_name=Davis Barometer, icon=mdi:gauge @ 2020-06-26T11:17:06.251640+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 1011.0
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_temperature, sensor_setting: sensor_temperature, sensor_name: sensor.davis_buitentemperatuur, sensor_state: <state sensor.davis_buitentemperatuur=27.6; unit_of_measurement=°C, friendly_name=Davis Buitentemperatuur, icon=mdi:thermometer @ 2020-06-26T11:17:26.276583+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 27.6
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_windspeed, sensor_setting: sensor_windspeed, sensor_name: sensor.davis_windsnelheid_gemiddeld, sensor_state: <state sensor.davis_windsnelheid_gemiddeld=4; unit_of_measurement=km/h, friendly_name=Davis Windsnelheid Gemiddeld, icon=mdi:weather-windy @ 2020-06-26T11:16:56.233385+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 4
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] rain: 0.0, snow: 0.0
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] skipped calculating evapotranspiration, got the following value from a sensor: 0.0
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Hourly Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: 9000, change percentage: 1.0, type: Hourly Adjusted Run Time
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state: just updated hourly_bucket_list: [0.0, 0.0, 0.0, 0.0]
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Hourly Adjusted Run Time
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_dewpoint, sensor_setting: sensor_dewpoint, sensor_name: sensor.davis_dauwpunt, sensor_state: <state sensor.davis_dauwpunt=16.8; unit_of_measurement=°C, friendly_name=Davis Dauwpunt, icon=mdi:thermometer @ 2020-06-26T11:16:56.233600+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 16.8
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_humidity, sensor_setting: sensor_humidity, sensor_name: sensor.davis_luchtvochtigheid, sensor_state: <state sensor.davis_luchtvochtigheid=52; unit_of_measurement=%, friendly_name=Davis Luchtvochtigheid, icon=mdi:water-percent @ 2020-06-26T11:12:37.587615+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 52
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_max_temperature, sensor_setting: sensor_max_temperature, sensor_name: sensor.davis_hoogste_temperatuur, sensor_state: <state sensor.davis_hoogste_temperatuur=27.8; unit_of_measurement=°C, friendly_name=Davis Hoogste Temperatuur, icon=mdi:weather-windy @ 2020-06-26T11:12:37.628639+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 27.8
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_min_temperature, sensor_setting: sensor_min_temperature, sensor_name: sensor.davis_laagste_temperatuur, sensor_state: <state sensor.davis_laagste_temperatuur=18.3; unit_of_measurement=°C, friendly_name=Davis Laagste Temperatuur, icon=mdi:weather-windy @ 2020-06-26T11:12:37.629338+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 18.3
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_precipitation, sensor_setting: sensor_precipitation, sensor_name: sensor.davis_regenhoveelheid_dag, sensor_state: <state sensor.davis_regenhoveelheid_dag=0.0; unit_of_measurement=mm, friendly_name=Davis Regenhoveelheid Dag, icon=mdi:weather-rainy @ 2020-06-26T11:12:37.588388+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 0.0
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_pressure, sensor_setting: sensor_pressure, sensor_name: sensor.davis_barometer, sensor_state: <state sensor.davis_barometer=1011.0; unit_of_measurement=mbar, friendly_name=Davis Barometer, icon=mdi:gauge @ 2020-06-26T11:17:06.251640+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 1011.0
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_temperature, sensor_setting: sensor_temperature, sensor_name: sensor.davis_buitentemperatuur, sensor_state: <state sensor.davis_buitentemperatuur=27.6; unit_of_measurement=°C, friendly_name=Davis Buitentemperatuur, icon=mdi:thermometer @ 2020-06-26T11:17:26.276583+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 27.6
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for type: Hourly Adjusted Run Time, source: use_owm_windspeed, sensor_setting: sensor_windspeed, sensor_name: sensor.davis_windsnelheid_gemiddeld, sensor_state: <state sensor.davis_windsnelheid_gemiddeld=4; unit_of_measurement=km/h, friendly_name=Davis Windsnelheid Gemiddeld, icon=mdi:weather-windy @ 2020-06-26T11:16:56.233385+02:00>
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 4
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] rain: 0.0, snow: 0.0
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] skipped calculating evapotranspiration, got the following value from a sensor: 0.0
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Hourly Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: 9000, change percentage: 1.0, type: Hourly Adjusted Run Time
2020-06-26 11:17:32 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state: just updated hourly_bucket_list: [0.0, 0.0, 0.0, 0.0, 0.0]

So it isn't calculating as it is missing the radiation sensor. The name of the radiation sensor: sensor.davis_zonnestraling i added it correctly during setup..

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

i think the check to see it ET sensor is used is not correct:

skipped calculating evapotranspiration, got the following value from a sensor: 0.0

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

@posixx - the logs you shared - is this for a component that is supposed to do the calculation of ET? Did you enable or disable calculation of ET in the first screen when you set up the component?

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Yes this is without ET sensor, so first wizardstep i kept the checkbox selected. After that i unselected all OWM sensors and used my own.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

hmm..more debugging to do then ;)

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

No hurry; I’m using ET sensor on my production system and that is working great..

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

OK, so the scenario where to use a ET sensor works fine? Awesome, that is good news. Its interesting that it would skip calculations in the scenario with just a solar radiation sensor.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Yes using ET sensor works great. Hourly sensor values:

image

And daily calculated based on that:

image

I only use ET sersors right now so if calculations are correct i don't know, my dev system is not runnign 24/7,,

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

Hi @posixx a new beta release is ready: 0.0.56 - please test it. I found a bug with the solar radiation, it should work now.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Ok as you can see i have configured solar sensor as it is mentioned at startup:

2020-07-01 10:16:08 INFO (MainThread) [custom_components.smart_irrigation] Smart Irrigation sources: {'use_owm_dewpoint': False, 'use_owm_humidity': False, 'use_owm_max_temperature': False, 'use_owm_min_temperature': False, 'use_owm_precipitation': False, 'use_owm_pressure': False, 'use_owm_temperature': False, 'use_owm_windspeed': False}
2020-07-01 10:16:08 INFO (MainThread) [custom_components.smart_irrigation] Smart Irrigation sensors: {'sensor_dewpoint': 'sensor.davis_dauwpunt', 'sensor_humidity': 'sensor.davis_luchtvochtigheid', 'sensor_max_temperature': 'sensor.davis_hoogste_temperatuur', 'sensor_min_temperature': 'sensor.davis_laagste_temperatuur', 'sensor_precipitation': 'sensor.davis_regenhoveelheid_dag', 'sensor_pressure': 'sensor.davis_barometer', 'sensor_solar_radiation': 'sensor.davis_zonnestraling', 'sensor_temperature': 'sensor.davis_buitentemperatuur', 'sensor_windspeed': 'sensor.davis_windsnelheid_gemiddeld'}

But i still get:

[custom_components.smart_irrigation.sensor] skipped calculating evapotranspiration, got the following value from a sensor: 0.0

None of the sensors i configured have a value of zero during this calculation, i double-checked. So the only issue which i can think of; youj check for a value for the evaporation sensor even when we have configured to not use that. Ofcourse that sensor value is zero / empty as it isn't configured.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

Wait a second I am not seeing the solar radiation in the sources. Did you remove /readd this instance of smart Irrigation? This is different from what I am seeing on my machine...

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

'sensor_solar_radiation': 'sensor.davis_zonnestraling' what do you mean it's not there?

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

It is in the sensors list yes, but no in the sources list. That sources list is passed from the setup and used to figure out which sensors might have been configured. I can try to refractor it now that I think of it. Regardless, I am seeing a flag for solar radiation in the sources list and you are not seeing it.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

I removed the integration and readded:

2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Hourly Adjusted Run Time. Bucket value was: 7.1484155556123525, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: -1, change percentage: 1.0, type: Hourly Adjusted Run Time
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state: just updated hourly_bucket_list: [7.1484155556123525]
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Hourly Adjusted Run Time
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: use_owm_precipitation, sensor_setting: sensor_precipitation, sensor_name: sensor.davis_regenhoveelheid_dag, sensor_state: <state sensor.davis_regenhoveelheid_dag=12.4; unit_of_measurement=mm, friendly_name=Davis Regenhoveelheid Dag, icon=mdi:weather-rainy @ 2020-07-01T17:41:39.626108+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 12.4
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: use_owm_temperature, sensor_setting: sensor_temperature, sensor_name: sensor.davis_buitentemperatuur, sensor_state: <state sensor.davis_buitentemperatuur=21.3; unit_of_measurement=°C, friendly_name=Davis Buitentemperatuur, icon=mdi:thermometer @ 2020-07-01T17:55:39.679069+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 21.3
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: use_owm_min_temperature, sensor_setting: sensor_min_temperature, sensor_name: sensor.davis_laagste_temperatuur, sensor_state: <state sensor.davis_laagste_temperatuur=16.7; unit_of_measurement=°C, friendly_name=Davis Laagste Temperatuur, icon=mdi:weather-windy @ 2020-07-01T10:19:01.054497+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 16.7
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: use_owm_max_temperature, sensor_setting: sensor_max_temperature, sensor_name: sensor.davis_hoogste_temperatuur, sensor_state: <state sensor.davis_hoogste_temperatuur=21.6; unit_of_measurement=°C, friendly_name=Davis Hoogste Temperatuur, icon=mdi:weather-windy @ 2020-07-01T17:38:01.235000+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 21.6
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: use_owm_dewpoint, sensor_setting: sensor_dewpoint, sensor_name: sensor.davis_dauwpunt, sensor_state: <state sensor.davis_dauwpunt=16.4; unit_of_measurement=°C, friendly_name=Davis Dauwpunt, icon=mdi:thermometer @ 2020-07-01T17:55:39.680206+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 16.4
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: use_owm_pressure, sensor_setting: sensor_pressure, sensor_name: sensor.davis_barometer, sensor_state: <state sensor.davis_barometer=1006.3; unit_of_measurement=mbar, friendly_name=Davis Barometer, icon=mdi:gauge @ 2020-07-01T17:55:09.595408+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 1006.3
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: use_owm_humidity, sensor_setting: sensor_humidity, sensor_name: sensor.davis_luchtvochtigheid, sensor_state: <state sensor.davis_luchtvochtigheid=74; unit_of_measurement=%, friendly_name=Davis Luchtvochtigheid, icon=mdi:water-percent @ 2020-07-01T17:55:39.678731+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 74
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: use_owm_windspeed, sensor_setting: sensor_windspeed, sensor_name: sensor.davis_windsnelheid_gemiddeld, sensor_state: <state sensor.davis_windsnelheid_gemiddeld=7; unit_of_measurement=km/h, friendly_name=Davis Windsnelheid Gemiddeld, icon=mdi:weather-windy @ 2020-07-01T17:55:34.125914+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 7
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state USING A SENSOR for instance Smart_Irrigation, type: Hourly Adjusted Run Time, source: calculate_solar_radiation, sensor_setting: sensor_solar_radiation, sensor_name: sensor.davis_zonnestraling, sensor_state: <state sensor.davis_zonnestraling=345; unit_of_measurement=W/m², friendly_name=Davis Zonnestraling, icon=mdi:white-balance-sunny @ 2020-07-01T17:54:19.678605+02:00>
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state state value: 345
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] rain: 12.4, snow: 0.0
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] calculated evapotranspiration: 5.251584444387648
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Hourly Adjusted Run Time. Bucket value was: 7.1484155556123525, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: -1, change percentage: 1.0, type: Hourly Adjusted Run Time
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state: just updated hourly_bucket_list: [7.1484155556123525, 7.1484155556123525]
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation] registering: type: Daily Adjusted Run Time, entity: sensor.smart_irrigation_daily_adjusted_run_time
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Daily Adjusted Run Time state: 0, attributes: {'water_budget': '0.0 %', 'bucket': '0.0 mm', 'lead_time': '0 s', 'maximum_duration': '9000 s', 'adjusted_run_time_minutes': '0.0 min', 'force_mode_duration': 0, 'force_mode_enabled': False, 'unit_of_measurement': 's', 'icon': 'mdi:sprinkler', 'friendly_name': 'Daily Adjusted Run Time'}
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Daily Adjusted Run Time, attribute: water_budget, attribute_value: 0.0 %, numeric_part: 0.0, show_units: False, a_val was str or contained ' ': True
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Daily Adjusted Run Time, attribute: bucket, attribute_value: 0.0 mm, numeric_part: 0.0, show_units: False, a_val was str or contained ' ': True
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_to_hass restoring state, settting bucket to: 0.0
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] async_added_t_hass type: Daily Adjusted Run Time, attribute: adjusted_run_time_minutes, attribute_value: 0.0 min, numeric_part: 0.0, show_units: False, a_val was str or contained ' ': True
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Daily Adjusted Run Time
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Daily Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: -1, change percentage: 1.0, type: Daily Adjusted Run Time
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] calculating wb and art for daily adjusted run time, result: {'wb': 0, 'art': 0}
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] update_state for type: Daily Adjusted Run Time
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Daily Adjusted Run Time. Bucket value was: 0.0, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: -1, change percentage: 1.0, type: Daily Adjusted Run Time
2020-07-01 17:55:41 INFO (MainThread) [custom_components.smart_irrigation.sensor] calculating wb and art for daily adjusted run time, result: {'wb': 0, 'art': 0}

Now it calculated the ET value correctly. I think modifying general settings does introduce the bug.

I'm away for an hour, when it updated again i will modify the integration setting it just as before to see if this introduces the problem,

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

well, something looks still off: https://pastebin.com/LPutaAKy

still see the message " skipped calculating evapotranspiration, got the following value from a sensor: 0.0"

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

yeah - I am working through refactoring stuff and testing it some more on my end. I think I have solar radiation working now. ET-from-a-sensor scenario looks better now as well. Give me a couple of minutes to wrap this into a new release. I got rid of the sources tracking (with the booleans) since it was really confusing - everything works on just the list of sensors now. It looks better on my end, but again, I am just using fake sensors.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

new beta release is available now: https://github.com/jeroenterheerdt/HAsmartirrigation/releases/tag/v0.0.57

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

ok updated the code and restarted HA: https://pastebin.com/dB2dv0vh

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

@posixx - which scenario is this paste for? It would be helpful if I know what I am looking at :) is this a scenario with solar radiation sensor or skipping ET calculation alltogether by supplying a sensor for ET?

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

And after 5 minutes: https://pastebin.com/k9EhVFFX

Looks good now!

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

I'm not testing using ET sensor as that is working fine in my production HA. This is for scenario WITH solar radiation sensor and WITHOUT ET sensor

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

this one was triggered after modifying intrgration settings: https://pastebin.com/JxaZTxJp

Still working. What i don't get is why it calculates evapotranspiration 6 times within the same second?

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

cool - thanks - not sure why the calculations happens multiple times, unless you have multiple instances configured.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

for my own sanity - if you are willing, please test the latest release with your ET sensor scenario as well (so skipping the calculations all together) so we know it still works :)

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

OK updated and restarted production HA; all looks good:

image

image

image

Let's see what the daily calculation does at 23:55: it has rained a lot today (13,8 mm) so this should give some negative bucket value right?

On devsystem i see hourly sensor value:

image

Looks like ET value of weatherstation doesn't count in rain??

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

It looks like the last screenshot is correct. I think the ET value you are getting from the sensor is just the ET value, not the "net" precipitation (precipitation - ET). If that is the case I am not sure the way the code works now is correct, because when you choose the option to enter a ET sensor, we skip all of the other config as I assumed it would be a "net" ET sensor, not just the ET. I can see if I can make that change back somehow, because it seems pretty clear that the ET sensor you have is just the ET, not the "net" precipitation.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Results after calculating daily runtime:

Using all sensors:
image

Using ET sensor:
image

So indeed the ET sensor doesn't calculate rain / snow.

I think we need to skip the ET sensor and only use the real sensors for calculation.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

right... or.... use the ET sensor for what it is but still provide the option to specify a precipitation sensor. because the combination would be all you need to calculate the 'net precipitation'. I will make some more changes soon! Thanks for all the testing!

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

https://github.com/jeroenterheerdt/HAsmartirrigation/releases/tag/v0.0.59 is ready - this changes the behavior of the ET sensor option and I think this is what we should be doing. let me know if it works correctly now.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Ok, uploaded new version but i don't see the option to add the precipitation sensor? I can only configure the ET sensor.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

so... this is what I am seeing:
image
and then in the next step:
image

are you not seeing the same?

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

I was wondering when you would go to sleep :)

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

:-) awake again. After restart i see the new wizard screen. Added both intergations using these 2 sensors, it looks good:

image

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

awesome! so you can confirm both scenarios work now? should we wait until tomorrow morning (for you) before we finalize this?

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Both scenario's work; i cannot comment on the values calculated as it looks these scenario's are completely different. My suggestion is to wait until tonight to see if calculated daily sensors are comparable.

component not using ET but actual weahterstation sensors:
image

component(s) using ET and rain sensor:
image

EDIT: voortuin is camparalble to the first sensor using actual sensors

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

cool, let's wait to see what it looks like for the daily and if it looks good we can wrap this up :)

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Ok so here it is:

Hourly and daily using ET calculation:

image
image

Hourly and daily using ET and rain sensors:

image
image

bucket value was the same for both environments. Calculation of the first doesn't seem to be ok?

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

What was the bucket before the update happened? Was it zero? I doubt it, but what was it?

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

It was 13.x something.. Don't know the exact value anymore.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

hmm, it is hard for me to understand what is going on here. can you reset or write down the bucket value before the update happens so we can troubleshoot? Please post the screenshots as well

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Ok values of Hourly and Daily sensors at 11:45:

image

image

Will post updated sensor values in about 10 minutes

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Ok so hourly didn't change, Daily bucket updated:

image

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

this looks good to me - I checked the numbers. Did you have rainy weather the last couple of days? The bucket is 12.44 mm now (after the update) and today the net precipitation is > 0 (0.53 mm) so the calculations look fine, but I just want to make sure that your experience is the same.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Yes it was a rainy day. I will look at the values of production tonight (which is using ET and rain sensor) to see if results are the same

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

the same might be asking for too much, but similar, yes, hopefully that is the case :)

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

OK, whites are DEV, blacks are PROD:

image
image

image
image

After 23:55 / daily calculation:

image
image

image
image

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Both calculations add/remove netto precipitation from bucket value. In case of ET sensor (= black screens) this is correct, in case of using all weatherstation sensors (white screens) it looks to me the calculated netto precipitation is not correct; this should be average of all hours combined.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

And the log from DEV:

2020-07-07 23:55:00 INFO (MainThread) [custom_components.smart_irrigation] Updating for last time today, calculating adjusted run time for next irrigation time!
2020-07-07 23:55:00 INFO (MainThread) [custom_components.smart_irrigation] ENTERING _update_last_of_day. bucket is 12.44702653775455
2020-07-07 23:55:00 INFO (MainThread) [custom_components.smart_irrigation] using OWM for precipitation: False
2020-07-07 23:55:00 INFO (MainThread) [custom_components.smart_irrigation] bucket_delta set to -0.935988357053827, which is the last item in the hourly bucket list: [-0.5092992142981276, -0.5092992142981276, -0.5016480038194464, -0.5016480038194464, -6.803924512283468, -6.803924512283468, -6.988053812097904, -6.988053812097904, -2.959287851299875, -2.959287851299875, -2.307660823628767, -2.307660823628767, -5.685743432961742, -5.685743432961742, -4.448010489006721, -4.448010489006721, -9.219427526104127, -9.219427526104127, -6.659999570202846, -6.659999570202846, -4.102193937051903, -4.102193937051903, -2.5169598627963707, -2.5169598627963707, -1.265911456360866, -1.265911456360866, -1.0046571769184682, -1.0046571769184682, -0.5782054736447511, -0.5782054736447511, -0.935988357053827, -0.935988357053827]
2020-07-07 23:55:00 INFO (MainThread) [custom_components.smart_irrigation] Updating bucket: 12.44702653775455 with netto_precipitation: -0.935988357053827, which should be average or last value of: [-0.5092992142981276, -0.5092992142981276, -0.5016480038194464, -0.5016480038194464, -6.803924512283468, -6.803924512283468, -6.988053812097904, -6.988053812097904, -2.959287851299875, -2.959287851299875, -2.307660823628767, -2.307660823628767, -5.685743432961742, -5.685743432961742, -4.448010489006721, -4.448010489006721, -9.219427526104127, -9.219427526104127, -6.659999570202846, -6.659999570202846, -4.102193937051903, -4.102193937051903, -2.5169598627963707, -2.5169598627963707, -1.265911456360866, -1.265911456360866, -1.0046571769184682, -1.0046571769184682, -0.5782054736447511, -0.5782054736447511, -0.935988357053827, -0.935988357053827]
2020-07-07 23:55:00 INFO (MainThread) [custom_components.smart_irrigation] hourly_bucket_list is now empty, bucket is 11.511038180700723
2020-07-07 23:55:00 INFO (MainThread) [custom_components.smart_irrigation] Bucket for today is: 11.511038180700723 mm
2020-07-07 23:55:00 INFO (SyncWorker_5) [custom_components.smart_irrigation.sensor] _bucket_updated, received bucket value 11.511038180700723 from event_dict: {'event_type': 'Smart_Irrigation_bucketUpd', 'data': {'bucket': 11.511038180700723}, 'origin': 'LOCAL', 'time_fired': datetime.datetime(2020, 7, 7, 21, 55, 0, 3054, tzinfo=), 'context': {'id': 'aea0baefe86d4d0c9d29f204d603f4b3', 'parent_id': None, 'user_id': None}}
2020-07-07 23:55:00 INFO (SyncWorker_5) [custom_components.smart_irrigation.sensor] updated_adjusted_run_time_from_event called.
2020-07-07 23:55:00 INFO (SyncWorker_5) [custom_components.smart_irrigation.sensor] Calculated water_budget = 0 and adjusted_run_time: 0 for type: Daily Adjusted Run Time. Bucket value was: 11.511038180700723, and base schedule index is: 686.0420650095604, force mode is: False, force mode duration is: 0, lead_time is: 0, maximum_duration: 9000, change percentage: 1.0, type: Daily Adjusted Run Time
2020-07-07 23:55:00 INFO (SyncWorker_5) [custom_components.smart_irrigation.sensor] updated_adjusted_run_time_from_event: got result: {'wb': 0, 'art': 0}. Setting attributes of daily adjusted run time (including result['wb']) and state == result['art']

Looking forward reading your comments in the morning:-)

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

thanks for providing the logs - so the DEV environment is doing as it is supposed to do - it is getting the latest value for precipitation and using that - since you are using a sensor that accumulates during the day this is what is expected. not sure why you think this should be different - didn't we agree before that you use the most recent value for precipitation when using a sensor for it and otherwise the average? that is exactly what is happening here.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

No DEV is calculating hourly precipitation based on weatherstation sensors, so this should calculate the average of all hourly calulations right? PROD is using ET value which is calculated by the weatherstation and the hourly value at 23:55 is the netto precipitation without rain.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

no - if you use a sensor for precipitation from a weatherstation we take the most recent value as it is expected to accumulate during the day (as yours does based on your screenshots before - see earlier in this thread) and smart weather does the same. so taking the most recent value is the appropriate action here.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Sorry Jeroen, but I think you are mixing up DEV and PROD. On the PROD screenshot you see precipitation building up during the day up to 2.896 mm. This is the ET sensor from my weatherstation.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

To me the solution is simple: DEV should calculate average over all hourly values, not taking the last:

2020-07-07 23:55:00 INFO (MainThread) [custom_components.smart_irrigation] bucket_delta set to -0.935988357053827, which is the last item in the hourly bucket list: [-0.5092992142981276, -0.5092992142981276, -0.5016480038194464, -0.5016480038194464, -6.803924512283468, -6.803924512283468, -6.988053812097904, -6.988053812097904, -2.959287851299875, -2.959287851299875, -2.307660823628767, -2.307660823628767, -5.685743432961742, -5.685743432961742, -4.448010489006721, -4.448010489006721, -9.219427526104127, -9.219427526104127, -6.659999570202846, -6.659999570202846, -4.102193937051903, -4.102193937051903, -2.5169598627963707, -2.5169598627963707, -1.265911456360866, -1.265911456360866, -1.0046571769184682, -1.0046571769184682, -0.5782054736447511, -0.5782054736447511, -0.935988357053827, -0.935988357053827]

These values are all calculated using temperature / humidity / solar radiation sensors, what’s the point of that if you only use the last value..

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

ok, I might be wrong here then, but I think we are just confusing multiple things here. happy to change the behavior, but we need to be crystal clear about which scenario we need to do what. Right now the update is happening hourly, so the bucket_delta list is updated hourly. That makes sense in all scenarios. Now, the trick is of course to figure out which item from the bucket_delta list to take. here I see two scenarios:

  • average - this is applicable when the values calculated are on point-in-time basis.
  • most recent - this is applicable when the values are based on accumulative sensors, such as what is the case with precipitation-during-the-day sensors as provided by most weather stations and smart weather.

Currently the logic is:
if we use OWM for precipitation we take the average of the bucket_delta list. In all other cases we get the most recent value of the bucket_delta list. Given that OWM is point-in-time I think that part is correct, but if we do not use OWM it becomes more tricky.
Basically the bucket_delta is precipitation - evapotranspiration. So, if you use a cumulative sensor for precipitation (which is expected) taking the most recent bucket_delta is the correct behavior. Keep in mind that at the time the bucket_delta list entry is calculated we still take whatever the value at that point is for solar radiation, humidity, temperature, etc (point-in-time values).
Just precipitation is accumulative, so whenever we use a sensor for that we need to take the most recent bucket_delta, NOT the average.

whether or not you specify a ET sensor does not matter here since that only tells us if we need to estimate evapotranspiration or we can just get value from a sensor - it only influences the second part of the bucket_delta calculation.

So I think the behavior is as it should be - precipitation sensors are normally cumulative during the day so taking the most recent entry from bucket_delta is correct as it is precipitation - evapotranspiration. When using a point in time value for precipitation (really only when using OWM) we take the average of bucket_delta. an ET sensor does not change this nor should it. If you ET sensor, however, also turns out to be accumulative we do need to change the current behavior.

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Hello Jeroen,

I did send you a link to see how Davis is calculating ET: https://www.davisinstruments.com/product_documents/weather/app_notes/AN_28-derived-weather-variables.pdf

As you can see at the hourly screenshot this is clearly a accumulated sensor which is reset to 0 at 0:00h:

image

BTW i use light theme during the day and switch to dark theme at nigt on PROD, so don't focus to much at white or black:-)

If i look at the values of the weatherstation ET calculation is calculated without rain (which is also a accumulated sensor):

image

So i would think the current ET sensor implementation is correct; You take the last value of ET sensor - last value of rain sensor = netto precipitation.

As the rainsensor is accumulated and the other sensors used in calculations aren't; to me it woul be better to calculate evapotranspiration based on sensors every hour WITHOUT rainsensor, and when calculating daily evapotranspiration take average of all hourly evapotranspiration values - accumulated rain sensor.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

ok, so apart from the last bit (which I don't think makes a lot of impact) we're good to go?

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Well; i think the daily values using real sensors need to be comparable to the daily values using ET/rain sensor. But apart from that were good to go!

If i'm adding up all hourly values and devide this by the number of calculations i get 3.4, which is a lot more comparable using ET sensor, which was 2,9

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

In your case I would go with ET sensor, since that is bound to be the most accurate. Other options in decreasing order of accuracy: would be going with sensors with solar radiation, sensors without solar radiation and OWM.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

thanks for confirming!

from hasmartirrigation.

posixx avatar posixx commented on August 26, 2024

Yes ET + rain will be my choice. I will upgrade to v0.0.62 to help regarding #42 so we can have a new Release shortly hopefully

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

@posixx you will be happy to learn that I have given this more thought and made a new release: https://github.com/jeroenterheerdt/HAsmartirrigation/releases/tag/v0.0.64. I have changed the behavior and will write it up in the documentation so there is less chance for us getting confused by the various scenarios.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

write up of the calculation behavior is here: https://github.com/jeroenterheerdt/HAsmartirrigation#getting-the-best-results. Please let me know if this makes sense.

from hasmartirrigation.

jeroenterheerdt avatar jeroenterheerdt commented on August 26, 2024

hey, all thanks to you. it took me a little bit to fully grasp where we needed to go and you kept me honest. Thanks for providing the feedback. Happy to close this though :)

from hasmartirrigation.

martin3000 avatar martin3000 commented on August 26, 2024

The fao56 function of pyeto wants the solar radiation in MJ per m² and day.
But the wiki says that solar radiation is in W/m², I think this is wrong.
The fao56 function returns a value for the whole day, so the input should also be daily values and not current values.

from hasmartirrigation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.