Coder Social home page Coder Social logo

Comments (3)

JeroenSormani avatar JeroenSormani commented on August 16, 2024

Hey @INOVEK,

Correct, it is possible duplicate coupons are generated. The changes to that are quite small though as there are 6212 (thats, like, a million-gazillion-empirerillion) possibilities, so I don't tend worry too much about those odds ;-)

Adding a check for existing coupons would give a huge slow down on the generation of the coupons (I've done a sh*t ton of testing and optimization on the generation process, including a check for existing coupon codes :-)

from woocommerce-coupon-generator.

nemeth-it avatar nemeth-it commented on August 16, 2024

But I think it would be a good idea to add this option. Especially when you allow in the future to change the length of the coupon-code and add prefixes, then a toggleable option would be nice.

Just because you say the possibilitie for this is quite small, so that it wouldn't happen. (it still remains possible)

from woocommerce-coupon-generator.

JeroenSormani avatar JeroenSormani commented on August 16, 2024

I'll take it in consideration as a option, but can't guarantee it.
So far I've not been very convinced of the amount of added value of it (I'm very careful with adding options to keep my plugins clean & lean).

Even when it happens that a duplicate coupon code is generated, the impact of that is almost irrelevant I believe.. (correct me if I'm wrong)

from woocommerce-coupon-generator.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.