Comments (3)
Interesting! Thanks for your suggestion. At first glance this seems like a nice improvement! Will try to look at it somewhere during the week, a bit busy at work at the moment.
from sample-angular-oauth2-oidc-with-auth-guards.
I just want to clarify exactly what caused my issue to justify the above added line.
It sometimes works fine, where isAuthenticated
is correctly true, and other times doesn't detect that the user is already authenticated.
It turned out that it was incorrectly false only right after I log in.
I traced this to the fact that if the timeoutFactor
on the access token is exceeded, then the setupAccessTokenTimer
function would trigger an event, and this would cause this line to run in the sample:
this.isAuthenticatedSubject$.next(this.oauthService.hasValidAccessToken());
However, if the token is not old enough for the token timer to fire when the page is loaded, there are no events at all that would trigger this code to run. The fix was to add this line to make sure it always runs initially when the app is loaded.
from sample-angular-oauth2-oidc-with-auth-guards.
Thx for the fix! I've added some tests and merged your PR. ♥🙏
from sample-angular-oauth2-oidc-with-auth-guards.
Related Issues (20)
- Add more unit test coverage for "copy-pastable" code
- Add observable to indicate if User Profile was loaded HOT 2
- Difference between this sample repository and the samples in the library's repository HOT 1
- Switch from demo.identityserver.io instance
- Microsoft Azure AD takes longer time on initial load with same setup HOT 6
- Getting silent_refresh_timeout right after "Content Security Policy" violation for "frame-ancestors 'none'" HOT 5
- Kicks me out a second after logging in HOT 5
- Steps for Azure AD HOT 2
- (Cross-post) Announcement about moderation of the library's community
- Question - Howto redirect to login page directly HOT 1
- Application logs out too quickly in Firefox HOT 1
- I stay authenticated even after i logout HOT 5
- Keep sending id_token as auth bearer HOT 1
- Update to Angular 16 HOT 1
- Replace Protractor with other end-to-end testing utilities HOT 3
- Consider dropping silent-refresh/iframe by using refresh endpoint HOT 3
- The attempt at silent refresh during the runInitialLoginSequence method can cause extremely long page loads if no token is present depending on the server used HOT 2
- Upgrade to Angular 17
- Auth service unit test is incorrect HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sample-angular-oauth2-oidc-with-auth-guards.