Coder Social home page Coder Social logo

Comments (6)

Jermolene avatar Jermolene commented on June 8, 2024 1

Hi @pmario in these situations I think it's clearer to add the tests in with the PR that includes the fix

from tiddlywiki5.

pmario avatar pmario commented on June 8, 2024

The unused "tooltip" construction {{{ [tag[docs]] |tooltip||TemplateTitle}}} is inconsistent with transclusion parameters, because the order is different.

To be able to cleanly fix bug-#7701 I do suggest, that we completely remove the unused regexp and the unused code.

So we will be able to add stuff back if we should need it in the future.

@Jermolene -- I do need a decision about this one to be able to fix #7701. To be able to fix #7701 in a clean way we need at least remove match-group 4, the "style" section

from tiddlywiki5.

Jermolene avatar Jermolene commented on June 8, 2024

Hi @pmario I would be inclined to agree that we should completely removed the unused parts of the regex and the associated code.

from tiddlywiki5.

pmario avatar pmario commented on June 8, 2024

@Jermolene ... I did add 4 new tests for filtered transclusions "inline" and "block" mode.

  • All tests pass with the new code.
  • 1 test fails with current master branch.

So should I include the test with the PR that fixes issues #7701 and #7797

or

Should I create a separated PR that only contains the tests.

-> The problem will be, that the vercel CI will fail those tests

from tiddlywiki5.

pmario avatar pmario commented on June 8, 2024

@Jermolene -- bump -- info needed

from tiddlywiki5.

pmario avatar pmario commented on June 8, 2024

The latest proposal from Jeremy is at: #7822 (comment)

Which can be changed to the following format, which gives us even more future possibilities.

vars ... can be any text except | -- even linebreaks are possible
params ... similar to vars but with basically no limitations

{{{ [tag[docs]] }}}
{{{ [tag[docs]] | vars }}}
{{{ [tag[docs]] || TemplateTitle }}}
{{{ [tag[docs]] | vars || TemplateTitle }}}

{{{ [tag[docs]] }} params }
{{{ [tag[docs]] }} param:"value" | another="value" }

{{{ [tag[docs]] }} param:"value" | another="value" | any text we want 
including line-breaks }

from tiddlywiki5.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.