Comments (6)
Hi @pmario in these situations I think it's clearer to add the tests in with the PR that includes the fix
from tiddlywiki5.
The unused "tooltip" construction {{{ [tag[docs]] |tooltip||TemplateTitle}}}
is inconsistent with transclusion parameters, because the order is different.
To be able to cleanly fix bug-#7701 I do suggest, that we completely remove the unused regexp and the unused code.
So we will be able to add stuff back if we should need it in the future.
@Jermolene -- I do need a decision about this one to be able to fix #7701. To be able to fix #7701 in a clean way we need at least remove match-group 4, the "style" section
from tiddlywiki5.
Hi @pmario I would be inclined to agree that we should completely removed the unused parts of the regex and the associated code.
from tiddlywiki5.
@Jermolene ... I did add 4 new tests for filtered transclusions "inline" and "block" mode.
- All tests pass with the new code.
- 1 test fails with current master branch.
So should I include the test with the PR that fixes issues #7701 and #7797
or
Should I create a separated PR that only contains the tests.
-> The problem will be, that the vercel CI will fail those tests
from tiddlywiki5.
@Jermolene -- bump -- info needed
from tiddlywiki5.
The latest proposal from Jeremy is at: #7822 (comment)
Which can be changed to the following format, which gives us even more future possibilities.
vars
... can be any text except |
-- even linebreaks are possible
params
... similar to vars
but with basically no limitations
{{{ [tag[docs]] }}}
{{{ [tag[docs]] | vars }}}
{{{ [tag[docs]] || TemplateTitle }}}
{{{ [tag[docs]] | vars || TemplateTitle }}}
{{{ [tag[docs]] }} params }
{{{ [tag[docs]] }} param:"value" | another="value" }
{{{ [tag[docs]] }} param:"value" | another="value" | any text we want
including line-breaks }
from tiddlywiki5.
Related Issues (20)
- The latest version of CodeMirror edit box, using textarea HOT 1
- [IDEA] Flex box syntax for in-tiddler multi-column HOT 2
- [BUG] $action-log always evaluates all functions in its context HOT 1
- [BUG] Uncaught TypeError: process.nextTick is not a function HOT 3
- [IDEA] Advanced Search Filter Tab Should Allow Multi-line Input HOT 1
- TW5-Syntax 2.0.0 Released HOT 8
- [BUG] EditTextWidget inserts extra space below content HOT 3
- [BUG] Plugin tests should not be applied to plugins that are loaded via environment variables HOT 5
- [IDEA] Meaningful Notifications for Permalink and Permaview Messages HOT 2
- [TESTS] all tests for a plugin-type "in development" fail, with no possibility to fix it HOT 3
- [IDEA] Allow Comments Inside $let HOT 5
- [BUG] Fix splitregexp operator JavaScript error on matches with undefined capture groups HOT 9
- [BUG] Unavoidable RSOD Caused by RegExp HOT 11
- [BUG] Tiddler editor layout has lost whitespace HOT 2
- [BUG] testcase procedure: "test failed" message displayed even though no ExpectedResult is defined HOT 1
- [IDEA] Store Tags as Displayed HOT 6
- [IDEA] Replace Plain Contents with Tree Contents in Plugin Tiddlers HOT 3
- Content wrong
- [BUG] `authenticated-user-header` broken for unauthenticated requests
- [IDEA] $action-log and $log widget should have "shortcut parameters" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tiddlywiki5.