TypeError: ShortNotes\PostType\Note\get_reply_to_markup(): Argument #1 ($post) must be of type WP_Post, null given, called in /var/www/html/wp-content/plugins/shortnotes/includes/post-type-note.php on line 383 about shortnotes

[aaronjorbin]

Yes, it looks like inside Yoast, the oembed data is filtered.

#45 is essentially what I did to get the error out of my logs, so I approved it. Thank you for being on top of this so quickly.

I do like the idea of bringing https://core.trac.wordpress.org/ticket/24330 back up for discussion

[aaronjorbin]

This is odd. It would seem as though get_post is returning null, even though we are inside the_content. I wonder if in these circumstances it would be best to just return $the_content?

[jeremyfelt]

@aaronjorbin good catch, thanks for reporting it! I'm guessing (hoping) you're filtering the oembed response to include an excerpt. Once I did that I was able to reproduce the issue.

The oembed handler figures out what the $post is based on the link, and then passes that around rather than set it globally. This leads to wp_trim_excerpt() not passing $post to its application of the_content.

So, I think you're right: best to just return $the_content when $post is not available. I've got a PR up for this in #45 if you want to take a look.

Aside: It looks like we almost had an expectation of $post_id as available context with https://core.trac.wordpress.org/ticket/24330, but it was pulled out. Thanks, Nacin. There is a remainder in do_trackbacks() though... Maybe it's time to bring the idea back now that blocks are flying all around.

[jeremyfelt]

Shipped in #45 and released in 1.6.2. Thanks again! 🍺