Unable to re-request Github check via Github following upgrade from 1.0.16 to 1.0.18 about github-checks-plugin

[timja]

Interesting, the workaround isn't hard though, push a new commit / re-run the build once via Jenkins?

Contribution welcomed though if someone wants to PR it.

Will close in a month or so if no fix as the stale jobs will naturally go away

[tslmy]

Facing the same issue.

I understand the effort constraints, but please consider this a serious problem, because this leads people to mistakenly believe that they have actually re-requested a Check Run.

How is it possible that people may be tricked to believe so?

Because every time "Re-run" is clicked, GitHub will show a blue banner that says,

You have successfully requested [check name here] be rerun.

and we can't expect all contributors to all repos using GitHub Checks Plugin to understand how Jenkins work with GitHub and realize that they have to distrust GitHub and check Jenkins for themselves.

Hence, regarding this statement,

the workaround isn't hard though, push a new commit / re-run the build once via Jenkins?

I would say this:

It's not about whether the workaround is hard or easy; it's about whether making people realize that they have to distrust a platform that they have trusted for a long while (in our case, GitHub) is hard or easy. In a way, this bug is getting serious because it undermines trust. It's about psychology; It's about thinking in non-Jenkins-savvy developers' shoes.

Thanks for your consideration.

[KalleOlaviNiemitalo]

When github-checks-plugin doesn't find the build that it should restart, it logs a warning:

github-checks-plugin/src/main/java/io/jenkins/plugins/checks/github/CheckRunGHEventSubscriber.java

Lines 130 to 131 in c98fc7b

	LOGGER.log(Level.WARNING, String.format("No build found for rerun request from repository: %s and id: %s",
	repository.getFullName(), checkRun.getCheckRun().getExternalId()).replaceAll("[\r\n]", ""));

Is there a response that Jenkins could return to GitHub in this situation, to prevent GitHub from claiming "You have successfully requested [check name here] be rerun"?
If that can be done, it seems a worthwhile change regardless of whether the problem was caused by a recent upgrade of github-checks-plugin.

GitHub check_run event documentation does not say anything about possible responses. Best practices for using webhooks advises that "Your server should respond with a 2XX response within 10 seconds of receiving a webhook delivery", which I suppose means that GitHub checks the HTTP status code at least.