Comments (4)
There is also BuildStatusChecksPublisher.JobScheduledListener.onEnterWaiting, which calls getChecksName with a Job rather than a Run: https://github.com/jenkinsci/checks-api-plugin/blob/4996cf43478acbd1a3043225af2b9d7849c6c174/src/main/java/io/jenkins/plugins/checks/status/BuildStatusChecksPublisher.java#L127-L129
I don't think that will ever be able to get the checks name defined in a pipeline script… but then again, it does not know the SCM settings defined in the pipeline either, so it won't be posting checks with an incorrect name to that SCM.
from github-checks-plugin.
You are right. onEnterWaiting
does not matter much in this scenario because the SCM is not present on the job so it won't publish anything. However, after the first checkout
step, it will start to publish in onCheckout
and onCompleted
because checkout
will add BuildData. But from there, we have access to the run object, so we could, if present, use information in the Run when scm is not defined.
from github-checks-plugin.
What should happen if the pipeline runs multiple checkout
steps, with a GitSCMStatusChecksExtension
in each? Should it publish IN_PROGRESS
to each repository after the corresponding checkout, and then COMPLETED
to every repository when the run completes?
from github-checks-plugin.
I think these can be 2 different problems. If the GitSCMChecksContext
uses the first build data only, then it should respect the associated GitSCMStatusChecksExtension
configuration of this build data. If it has a mechanism to loop through all buildData (from different checkout steps), then it should respect their own configuration and publish the completed check for all of them.
I think the first step would be to be able to get the GitSCMStatusChecksExtension
for a specific build data first.
When that is working, sending a check for multiple checkout step could be added. I can easily imagine a use case where there are 2 checkouts, but only the second one is in the right repo and should have the check. The user would need to specify in the first checkout to skip the check.
from github-checks-plugin.
Related Issues (20)
- Unable to connect using GitHub SCM and github app credentials
- Dependency Dashboard
- Using environment variable for status checks name
- Re-enable integrations tests
- Updating status checks on merge of PR instead of head
- Pick up organization name in GitHub multi-branch job HOT 2
- Head of build log is not useful in failures
- Failed Publishing GitHub checks - Only 65535 characters are allowed; 65537 were supplied. HOT 8
- Broken using SSH credentials with this plugin
- GitHub checks not published despite successful job execution
- GitHub Checks is spamming the logs HOT 3
- Chess incorrectly report success on failed stage if junit is enabled and not failing
- Configuration ignores app credential override
- Checks fail if run on system locked out of public internet. HOT 5
- Couldn't authenticate with GitHub App for Checks without owner defined (single org) HOT 6
- Add getting started documentation
- Manual builds throw an exception when they run HOT 2
- Plugin not publishing completed status checks back to the correct commit under rare cases
- "github checks plugin" does not work in jenkins 2.426.3-lts HOT 1
- Support for multibranch pipelines outside of GitHub org that use GitHub repo and app credentials HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-checks-plugin.