Icons don't display for "SSH User Private Key" & "Certificate" credentials types about aws-secrets-manager-credentials-provider-plugin

[chriskilding]

I believe this was caused by the credentials API plugin moving to a new icon for these credential types. The new icons have different names to the old icons. Because the AWS provider credentials still use the old icon names, they're now out of sync with the credentials API plugin - that's why you don't see the correct icon for them (or you see a broken icon.

The changes I've seen are:

• SSH key: icon-fingerprint -> symbol-fingerprint
• Certificate: icon-credentials-certificate -> icon-application-certificate

In #216 I updated the icon used for the SSH key. Your bug report shows that other credential types may also have new icons. Could you let me know the new icon name for the Certificate type (and maybe the other main credential types) that you see in your Web inspector console? That way I can include these fixes in the PR as well.

[exoaturner]

Thanks @chriskilding

I went through each of the secrets your plugin supports and expected "working" versions of the icons. I hope the below is useful:

string (Kind: secret text) -> symbol-key

usernamePassword (Kind: Username with password) -> symbol-id-card

sshUserPrivateKey (Kind: SSH Username with private key) -> symbol-fingerprint

certificate (Kind: certificate) -> icon-application-certificate

file (Kind: Secret file) -> symbol-key

Kind regards,
Aaron

[chriskilding]

Thanks :)

The AWS implementations of the String and File credentials don't override getIconClassName(). This means they inherit the credentials API plugin's default icon name. That stays current with whatever the default credentials provider does, so essentially it's always correct.

The only credential types that need updating in code are the ones that do override getIconClassName. That obviously includes SSH Key and Certificate. It also includes Username and Password. I'll get those done in #216.

For the Certificate type, it looks like there is a further change coming down the pipe; the new name is icon-application-certificate, however if you look in Jenkins core, you see they've changed this again to symbol-ribbon. This change has not yet propagated to the Credentials API plugin but it will do eventually. This means we're looking at another breaking icon change down the line.

[chriskilding]

Hi, version 1.198.v839f082578db is now released which contains fixes for the icons as they stand today.

If you could install that and confirm whether it fixes the issues you saw, that would be great.

Btw the new minimum supported Jenkins version of the plugin is 2.346.3