Combine "In progress" and "Next up" as "Continue" about jellycon

[mcarlton00]

I would agree that having the In Progress stuff in front makes the most sense, and that's the same way I was thinking of implementing it. @Ozymandyaz feel free to open a PR if you're comfortable sharing.

Apologies for being MIA for a while. I recently bought a house and moved across town and have had a bunch of IRL stuff keeping me busy, so I just haven't had a bunch of dev time available.

[Ozymandyaz]

PR submitted, but please keep in mind that my Python skills consist of watching a YouTube video one day.... That being said... This works for me, and if anyone wants to hack it together the same way, just edit widgets.py with the changes directly on your Kodi install...

[mcarlton00]

I agree with the principle of joining them, but I worry that doing so now will break whatever shortcuts people may have set up. It would need some thought first. The options I see right now:

• Join them, have both previous sections point to the combined view
• Make it a user configurable setting
• Make it a third combined view and leave the two original view alone

[ltguillaume]

I think the third option is the best in terms of compatibility: nothing breaks, nothing changes, just a useful extra item. That is probably the easiest to implement, too.

Personally I'd go with the first option, but I think there might be use cases where combining the two into 20 items max. would not suffice for some people.

[quixventure]

I agree 100% on both counts.

There should be a combined list and it makes sense to make it a new item.

However this behavior was introduced in 10.7.5 so its unlikely that anyone has config that depends on it.

[Ozymandyaz]

As an FYI - I was able to "fix" this issue on my own install by modifying the widgets.py file and making the NextUp Episodes custom widget grab both sets and then just combine the results. Its really hokey and the In Progress are always at the front of the list, but for me that's OK cuz I usually only have one or two and they are usually what i want to continue watching and it works fine in Embruary.

[ltguillaume]

@Ozymandyaz That sounds like a great solution already. I think it's best to have the "In Progress" items at the top anyway.

Perhaps you can create a pull request (e.g. renaming "Next Up" to "Continue watching") and see what @mcarlton00 thinks of it?

[mcarlton00]

Closed by #82

[ltguillaume]

I just updated to 0.4.5, but Next Up does not show any of the In Progress items...

I looked through the code, there doesn't seem to be an option that should be flicked, so what's going on?

I'm on Kodi 18.9

[mcarlton00]

It was added into the "widgets" function, but not the library folders. Addons -> JellyCon -> Custom Widgets.

Probably should have been added to the other folders as well, but I didn't think about it at the time.

[ltguillaume]

Aaah I get it. Yeah, that's rather confusing imho.

[mcarlton00]

The widgets were fairly straightforward once a path was chosen, and the way the code is laid out made it easy to single them out. The menu items would basically have to be done somewhere in this file: https://github.com/jellyfin/jellycon/blob/master/resources/lib/dir_functions.py

Notably, there's a lot less separation and would need some a good chunk of extra logic thrown in somewhere to make it work. I'm not sure where it would even fit at this point

[ltguillaume]

Understood. You could just show the user the difference between the two by giving the now-combined widget another name, e.g. "Continue watching", so that there is a clear distinction between that and "Next Up".