JSON::ParserError in Apitome::Docs#index about apitome

[alejandro-vericatch]

Hey guys, could you release the fixes #115? I would appreciate it. Thanks!

[ukazap]

Update the Gemfile for temporary fix:

gem "apitome", github: "jejacks0n/apitome"

[bf4]

I made a PR #115

gonna test it in my app

[ShamoX]

@jejacks0n Can you release the fix please ?
I made a PR #118 that fixes the build

[daviidy]

Update the Gemfile for temporary fix:

gem "apitome", github: "jejacks0n/apitome"

It worked for me. Thanks!

[bf4]

fwiw, I'm researching this now myself. looks like you're on rails 6.0.2.1. I'm on Rails 5.2. did you just upgrade rails? have you ever had it working?

[jejacks0n]

Any fix for this would be appreciated. =) I currently don't have time to look into it.

[bf4]

I think this is a duplicate of #113

[bf4]

Issue for me appears to be that rspec_api_documentation may return the string "[binary data]" as the response body, and this makes apitome blow up.

https://github.com/zipmark/rspec_api_documentation/blob/560c3bdc7bd5581e7c223334390221ecfc910be8/lib/rspec_api_documentation/client_base.rb#L88-L96

I'd like to propose adding a user-configurable error handler to handle this in addition to a fix

either in the controller

apitome/app/controllers/apitome/docs_controller.rb

Lines 82 to 91 in cf53a41

	def formatted_body(body, type)
	if type =~ /json/ && body.present?
	JSON.pretty_generate(JSON.parse(body))
	else
	body
	end
	rescue JSON::ParserError
	return body if body == " "
	raise JSON::ParserError
	end

or in the view which knows which request is the problematic one

apitome/app/views/apitome/docs/_example.html.erb

Lines 7 to 27 in 6b715aa

	<% example['requests'].each_with_index do |request, index| %>
	<div id="<%= "request-#{index}" %>">
	<h3><%= t(:request, scope: :apitome) %></h3>
	<div class="request">
	<%= render partial: 'apitome/docs/route', locals: {request: request, index: index} %>
	<%= render partial: 'apitome/docs/headers', locals: {request: request, index: index, headers: request['request_headers']} %>
	<%= render partial: 'apitome/docs/query', locals: {request: request, index: index} unless request['request_query_parameters'].empty? %>
	<%= render partial: 'apitome/docs/body', locals: {request: request, index: index, body: request['request_body'], type: request['request_content_type']} if request['request_body'] %>
	<%= render partial: 'apitome/docs/curl', locals: {request: request, index: index} if request['curl'] %>
	</div>
	<h3><%= t(:response, scope: :apitome) %></h3>
	<div class="response">
	<%- if Apitome.configuration.simulated_response %>
	<%= link_to('Simulated Response', simulated_path(example[:link])) if example[:link].present? %>
	<%- end %>
	<%= render partial: 'apitome/docs/response_fields', locals: {params: example['response_fields']} if example['response_fields'].size > 0 %>
	<%= render partial: 'apitome/docs/status', locals: {request: request, index: index} %>
	<%= render partial: 'apitome/docs/headers', locals: {request: request, index: index, headers: request['response_headers']} %>
	<%= render partial: 'apitome/docs/body', locals: {request: request, index: index, body: request['response_body'], type: request['response_content_type']} if request['response_body'] %>
	</div>

[KiranJosh]

fwiw, I'm researching this now myself. looks like you're on rails 6.0.2.1. I'm on Rails 5.2. did you just upgrade rails? have you ever had it working?

I have integrated apitome in new app only. It was working before upgrading rspec-rails to 4.0.0.

[KiranJosh]

I made a PR #115

gonna test it in my app

Thanks, its working.

[bf4]

Issue was a change in rack and naive logic in rspec api doc with poor handling in apitome

[Payal13]

I am facing the same issue. What should I do ? is this fix released?

[alejandro-vericatch]

I am facing the same issue. What should I do ? is this fix released?

Have a look at issue #115, there fix the problem.

[ratnarajsukale]

gem "apitome", github: "jejacks0n/apitome"
this works

[xrnm]

Seeing as #115 has been merged should this be marked as closed?