Doesn't work with solarized colorscheme about icdiff

[bruno-]

Hm.. I jumped the gun by opening this issue.
I managed to find and correct the problem myself. I've submitted #7.
Things now work both in the "regular" terminal and the one with solarized colorscheme.

From what I see icdiff uses highlighted colors and not the regular ones (or whatever they are called).
Is there a reason to use highlighted colors?

[jeffkaufman]

icdiff currently uses "bold" colors for two reasons: (a) when a changed section consists of whitespace changes only it needs to highlight the whitespace, and you can only do this with bold, and (b) in my colorscheme I think the bold colors are easier to see.

I'm happy to add a flag for this that uses non-bold colors, except for the case of (a). Let me have a look.

[bruno-]

Hmm.. yes, you are right about (a). After you said this I realized I don't see whitespace changes when using non-bold colors locally..

[jeffkaufman]

Actually, I think (a) isn't really a problem, and is just an issue with the hacky show_all_spaces regexp I'm using.

[bruno-]

Ah yes.. it seems the regex there presumes a bold color is used.

After changing the regex to assume "regular" color is used (basically changing the 1 to 0) I can confirm the whitespace diff, is now visible!

[jeffkaufman]

Ok; if you update icdiff and give it the --no-bold argument then you'll get something that should work better for you.

[bruno-]

Thanks a lot 👍