Coder Social home page Coder Social logo

Comments (7)

dcousens avatar dcousens commented on April 28, 2024

@furqanZafar but you also have the case where if you omit a value="apple", the value is not nothing, but still changeable by a user, and onChange events are still fired.

Its more like, the prop is the optional source, but if it is omitted, the component assumes manages it instead.

At least, that is my understanding of how it should be. I'm still investigating whether this is actually the case.

from react-select.

jamesjjk avatar jamesjjk commented on April 28, 2024

@dcousens @furqanZafar I believe this is still an issue - renders it difficult to use this component.. When utilising setState on any event it would trigger a render of the component..

from react-select.

furqanZafar avatar furqanZafar commented on April 28, 2024

I ended up writing a whole new component that is completely stateless and avoids synchronisation of props with state.

It uses state for a particular value only if the user does not provide that value via props, otherwise it uses the value directly from props. This overcomes the problem stated by @dcousens, And makes it easier to maintain & add features.

https://github.com/furqanZafar/react-selectize

from react-select.

jamesjjk avatar jamesjjk commented on April 28, 2024

@furqanZafar Thanks for sharing that, really nice piece of work - should put it out there, its very well written and overcomes the problems and anti-pattern used with react-select.

from react-select.

dcousens avatar dcousens commented on April 28, 2024

Really nice component @furqanZafar
I've not seen Livescript before either :)

from react-select.

furqanZafar avatar furqanZafar commented on April 28, 2024

Thanks!

Livescript has really helped speed up development time & improve code readability, one of the objectives of react-selectize is to raise awareness about how well Livescript gels with ReactJS due there functional nature.

Livescript is pretty, concise with rich syntax sugar, some of which just recently started appearing in ES6 such as destructuring (or pattern matching), enhanced object literals, template strings, classes & much more...

from react-select.

gwyneplaine avatar gwyneplaine commented on April 28, 2024

this is resolved in v2, we now maintain a separate stream for controlled props and internally managed state values. Please see the following docs for details.

from react-select.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.