Coder Social home page Coder Social logo

Comments (6)

JedWatson avatar JedWatson commented on April 28, 2024

I would love to do that, but unfortunately it breaks the build process if you are using browserify and haven't included reactify as a dependency of the project where the build is happening.

It seems like a lesser of two evils thing: either

  • webpack (or other build process) users get a package installed from npm that they don't need, or
  • browserify users who aren't using reactify will get an obscure error

I'll see if I can work out a better strategy for both ecosystems...

from react-select.

JedWatson avatar JedWatson commented on April 28, 2024

TBH I am considering switching from JSX to React.createElement(... syntax.

I find JSX much clearer for visualising DOM structure but don't love the build-related mess it creates supporting both browserify and webpack.

from react-select.

julen avatar julen commented on April 28, 2024

For library consumers the best thing is publishing code that needs no transformation — this issue and #26 wouldn't exist in the first place. And users of any other module bundlers wouldn't be affected either.

You can still keep using JSX for development (so reactify goes in devDependencies), but you only publish to npm the scripts transformed to React — you could whitelist files by using the files field in package.json or blacklist them in the .npmignore file.

(Note that you can also leverage files/.npmignore to reduce the download size to the bare minimum. Consumers will be happy to have faster downloads!)

from react-select.

JedWatson avatar JedWatson commented on April 28, 2024

@julen I think I'll go with your suggestion here if we don't come up with a better idea in #40, especially given #38. I'm already publishing code that doesn't need transformation for standalone use, was just expecting that if you've got a browserify / web pack build process in your project and are using React, JSX transformation wouldn't be an issue.

from react-select.

JedWatson avatar JedWatson commented on April 28, 2024

I've updated the build process to pre-build JSX to a /lib directory, which package.json is now pointed at. So this should be all cleaned up now.

from react-select.

julen avatar julen commented on April 28, 2024

Just verified this on my side and everything works like a charm without special-casing 👍

Many thanks!

from react-select.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.