Comments (6)
I would love to do that, but unfortunately it breaks the build process if you are using browserify and haven't included reactify
as a dependency of the project where the build is happening.
It seems like a lesser of two evils thing: either
- webpack (or other build process) users get a package installed from npm that they don't need, or
- browserify users who aren't using reactify will get an obscure error
I'll see if I can work out a better strategy for both ecosystems...
from react-select.
TBH I am considering switching from JSX to React.createElement(...
syntax.
I find JSX much clearer for visualising DOM structure but don't love the build-related mess it creates supporting both browserify and webpack.
from react-select.
For library consumers the best thing is publishing code that needs no transformation — this issue and #26 wouldn't exist in the first place. And users of any other module bundlers wouldn't be affected either.
You can still keep using JSX for development (so reactify
goes in devDependencies
), but you only publish to npm the scripts transformed to React — you could whitelist files by using the files
field in package.json
or blacklist them in the .npmignore
file.
(Note that you can also leverage files
/.npmignore
to reduce the download size to the bare minimum. Consumers will be happy to have faster downloads!)
from react-select.
@julen I think I'll go with your suggestion here if we don't come up with a better idea in #40, especially given #38. I'm already publishing code that doesn't need transformation for standalone use, was just expecting that if you've got a browserify / web pack build process in your project and are using React, JSX transformation wouldn't be an issue.
from react-select.
I've updated the build process to pre-build JSX to a /lib
directory, which package.json
is now pointed at. So this should be all cleaned up now.
from react-select.
Just verified this on my side and everything works like a charm without special-casing 👍
Many thanks!
from react-select.
Related Issues (20)
- MenuPortal placement is off for position='fixed' if a parent has transform: scale
- Cannot select options on iOS with VoiceOver since 5.8.0 HOT 1
- MS Edge 119: text cut in placeholder/selected option HOT 1
- Name property is not defined for option in the animation color dropdown.
- autoComplete overlaps the input field on v5 HOT 1
- <title> OMG HOT 1
- react-select v5.8.0: `Extra attributes from the server: aria-activedescendant` HOT 3
- Async multi select options are reset after selecting an option HOT 2
- Issue with input type="number" on Firefox/Safari HOT 2
- Menu is closing inside tests HOT 4
- Validation works incorrectly for React-select with Formik and yup on mobile device
- JAWS screen reader highlight/focus issue
- Bug: right clicking on a select input when the menu is open makes the input unresponsive
- Inconsistent Behavior With Magnification When Selecting Dropdowns
- Inconsistent Behavior With Magnification When Selecting Dropdowns
- Pressing on Tab key takes me to outside of the form instead of next input. HOT 9
- <withAsyncPaginate: the options menu closes on every option click>
- The issue where the keyboard's down button does not work immediately during Korean input
- Extra Space in Dropdown Menu of React Select Component on Initial Render
- not showing the inital value HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-select.