Comments (11)
Huh, I don't think it's environment variables, maybe it failed to npm install
within the core-js
folder. In any case I need to investigate if the core-js custom build is even necessary anymore, since Meteor now has some builtin ES2015 support they may have fixed the Number
constructor issue.
from meteor-webpack-react.
By looking at the error message I would think the same. But When running npm install
and then node dev.js
the corejs build runs fine.
So this happens only when using deploy.js
instead of dev.js
- on the same environment with the git repository cleaned before running the script.
from meteor-webpack-react.
I'm still getting the match
errors when doing something like collection.find({}, {limit: 3})
due to the Number
constructor polyfill with the latest version of Meteor...which would mean they're doing something weird to support it with their ES2015 plugin that doesn't also apply to externally transpiled code.
I should log an issue in their tracker about this...
from meteor-webpack-react.
Have you tried this on clean install? This would certainly indicate that the npm install
call from core-js-custom-build.js
isn't working on your CI server
> npm install
> cd node_modules/core-js
> npm install
> cd ../..
> node deploy.js meteor.com
from meteor-webpack-react.
Yes, this happens on a clean install of the current master of this skeleton.
And not only on my CI server (Debian) but also on my local machine (Arch Linux) - both node 4.1 and npm 3.
Running npm install manually on the core-js folder as you suggested helped. So there seems to be a problem with the "core-js-custom-build.js" call - but only in deploy.js. As it's called the same way there must be some difference somewhere else...
from meteor-webpack-react.
Weird. I do need to start using the latest versions of Node. I wonder if shelljs can cause any problems...I've noticed that exec
calls swallow dynamic things printed to the terminal, like download progress meters that would show when running the core-js custom build via bash script.
I may not have much more time leftover to work on this project this week...but feel free to make a PR if you figure out what's wrong
from meteor-webpack-react.
Pardon my off topic. But which version of node is recommended? I am using 0.10.40 for compatibility issues with Meteor.
from meteor-webpack-react.
I'm using latest node 4.1.2 and npm 3.3.5 and don't have any issues.
jedwards1211 wrote:
Weird. I do need to start using the latest versions of Node
I assume this skeleton is tested with older versions of node
@tomitrescak what kind of compatibility issues do you have with meteor? I thought the meteor install includes node and is in independed from the system wide installed version.
from meteor-webpack-react.
@JBBr Not even Node 0.12.x was recommended for meteor. If you use MUP or some other deploy tools, the 0.10.40 is the latest they install. I did not try to discover why is that, just accepted it as a fact.
from meteor-webpack-react.
@tomitrescak Yes that's true for running meteor bundles directly with node (e.g. using meteor bundle
or demeteorizer).
But in the skeleton the meteor command is executed in the background. Node is only used to run some scripts and webpack/webpack-dev-server.
The meteor server is still using the included node version (maybe still 0.10.x, maybe updated in Meteor 1.2)
from meteor-webpack-react.
Back to topic @jedwards1211:
I've found a way to fix the problem. It does only occur if core-js-custom-build
is required inside a exported function (module.exports).
If it's required before module.exports
build runs fine.
I'll do a PR
from meteor-webpack-react.
Related Issues (20)
- Stripe integration HOT 1
- Calling configure method of useraccounts package causes error HOT 2
- WebPack Syntax Error on Windows
- Why would dev.js build server only?? HOT 2
- CoffeeScript/ Usage with meteord HOT 2
- How to: Server side debugging? HOT 2
- npm WARN deprecated [email protected]: lodash@<2.0.0 is no longer maintained. Upgrade to lodash@^3.0.0 npm WARN deprecated [email protected]: lodash@<2.0.0 is no longer maintained. Upgrade to lodash@^3.0.0 HOT 3
- TypeError: Cannot read property 'loginButtons' of undefined HOT 4
- Screen stays at "Loading" HOT 2
- mailgun-js HOT 2
- Meteor 1.3 HOT 18
- Adding loaders to webpack.config.client.js HOT 2
- Code splitting doesn't work in production (because only main chunk gets copied to meteor folder) HOT 12
- Cannot import meteor modules HOT 1
- Problem using Elasticsearch HOT 4
- Weird debug issues -- out of the box HOT 1
- [ERROR] Cannot find Cannot find module 'temp' , core-js-no-number when running dev HOT 2
- GET http://localhost:9090/ 502 Bad Gateway HOT 6
- Trying to bundle a pure node.js application HOT 2
- Webpack issue loading static files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor-webpack-react.