Coder Social home page Coder Social logo

Comments (6)

AdamBrodzinski avatar AdamBrodzinski commented on June 27, 2024

Ah lol thanks for the heads up!!

from meteor-webpack-react.

jedwards1211 avatar jedwards1211 commented on June 27, 2024

Ah, so with, root: path.join(__dirname, '..') I get the following compile error:

ERROR in ../debug
Module parse failed: /home/andy/meteor-webpack-react/debug Line 1: Unexpected token ILLEGAL
You may need an appropriate loader to handle this file type.
| #!/bin/bash
| 
| ./core-js-custom-build
 @ ../~/webpack-dev-server/~/socket.io-client/lib/index.js 9:12-28

I think it would make the most sense to rename the app folder to src and make it the webpack root.
@AdamBrodzinski what do you think?

from meteor-webpack-react.

jthomaschewski avatar jthomaschewski commented on June 27, 2024

I've been using root: path.join(__dirname, '../app') for a while now and didn't experienced any problems.

Imports are relative to the app directory import App from 'components/App'; - So your idea of renaming to src should work fine as I'm using app already like that without any issues.

btw: Webstorm IDE is only able to find imports if I do them relative to the app directory - at least in default configuration when opening "meteor-webpack-react" folder as project. I have no idea why but for me the root => ../app or ../src solution is the best so far.

from meteor-webpack-react.

AdamBrodzinski avatar AdamBrodzinski commented on June 27, 2024

root: path.join(__dirname, '..') works for me too, thanks again! I think we should prob. include this unless you think it will error on some cases.

from meteor-webpack-react.

jedwards1211 avatar jedwards1211 commented on June 27, 2024

@AdamBrodzinski you didn't have that same issue with root: path.join(__dirname, '..')? Weird...in any case I think having the app folder as root makes the most sense, because we're encouraging users to put all of their own code there anyway.

from meteor-webpack-react.

AdamBrodzinski avatar AdamBrodzinski commented on June 27, 2024

oh yea speaking of renaming to src is ok with me too (i think that was another issue), either way works for me.

from meteor-webpack-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.