Coder Social home page Coder Social logo

Comments (1)

jedisct1 avatar jedisct1 commented on May 23, 2024 1

I don't think Polly is expected to play well with code using architecture-specific vector instructions.

libsodium code (and cryptographic code in general) is full of already vectorized implementations, unrolled loops, and the rest can hardly be vectorized. That's the worst possible case for Polly, so performance regressions are more likely than performance gains.

Most importantly, Polly is mainly a research project. And regardless of the test suite results, using this in a crypto library (or any experimental compiler optimization pass) is a terrible idea. An edge case not caught by the test suite could have catastrophic implications.

Libsodium may work with Polly if you disable all the AVX/AVX2/AVX512 implementations. But then, you'll end up with code that's very slow.

If you want to investigate that issue, go ahead. But unless it looks like a ton of work for something that's not worth it and that no one besides you is, or should be doing.

You are a smart person and know that nothing is going to happen by keeping that issue open, unless you get your hands dirty, or find a way to reproduce the same test failures with common, non-experimental optimization passes.

In the meantime, the documentation will be updated to explicitly discourage usage of Polly and other experimental optimization passes.

from libsodium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.