Comments (6)
Everything seems to be fine in CI:
libsodium/.github/workflows/ci.yml
Lines 158 to 180 in 176923f
https://github.com/jedisct1/libsodium/actions/runs/4009408847/jobs/6884725366
Are you using the same NDK version? (r25b)
from libsodium.
I just successfully compiled the armv7 version on an x86-64 macbook pro using the latest from git and the latest ndk (25.1.8937393 which I believe is the same as r25b). @cmonfortep please confirm you are also using the latest from git and the latest ndk. Also do you maybe have more than one ndk installed or alternatively have you modified the ndk in anyway or done anything that could have done so? My best guess is a corrupted ndk if you haven't deliberately changed it try uninstalling and reinstalling the ndk and see if the issue is fixed.
from libsodium.
/cc @ReenigneCA
from libsodium.
Thanks for the quick response.
The latest version of git, yes. But an old version of ndk (21.4.7075529
, we use that version to compile other internal c libraries). I've just downloaded ndk version 25 and I confirm it works.
So that confirms the issue is the ndk version I was using. I will need to check with the team if we can bump ndk version. Are you aware of why using ndk 25 fixes it?
from libsodium.
The quick answer is that the toolchain was before the current aar script was written so it was never tested against. I'm more surprised that any of the scripts work to be honest the old libsodium scripts used to create toolchains for each platform, which was the legacy approach to the ndk (it was pretty crazy you'd have a huge toolchain directory structure created for each version of each thing you'd compile). Looking at the ndk changelog it appears that the version you're using was a transitional version between the old and new approaches:
"The legacy toolchain install paths will be removed over the coming releases. These paths have been obsolete since NDK r19 and take up a considerable amount of space in the NDK. The paths being removed are"
So I'd guess that some important files moved around in the process or maybe even were added or renamed or something. It is likely possible to get it working either by modifying some flags in the current scripts or going back to the previous versions of the scripts and modifying them to work with the script that packs the outputs into the AAR. The old build scripts are still bundled in the stable release on the libsodium site.
from libsodium.
Thanks for the explanation @ReenigneCA 👍
from libsodium.
Related Issues (20)
- android-ndk-r26-rc1 build error for stable HOT 6
- Why soname change from 23 to 26 HOT 1
- [UB] memcpy could be called on null dst pointer in function escrypt_r HOT 2
- Shouldn't crypto_pwdhash_PRIMITIVE be 'argon2id' ? HOT 1
- LATEST.tar.gz.sig is missing HOT 1
- Request to add amalgamation build HOT 2
- Compilation issues
- Build tries to use AVX on i386 when no support for them available HOT 9
- 64 bytes for the hash in `crypto_box_curve25519xsalsa20poly1305_seed_keypair(..)`? HOT 1
- Sodium.Core Nuget package version 1.3.4 is not getting installed in .Net 4.8 project HOT 1
- Support for Windows Arm64
- Zig build for windows platform issue HOT 1
- FreeBSD: aarch64 build fails HOT 6
- 1.0.19 mistagged? HOT 4
- `crypto_kdf_hkdf_sha{256,512}_extract_final` use `sizeof` on a pointer (in code which currently is actually not buggy)
- Several calls to `fe25519_abs` trigger `memcpy` undefined behavior
- is hashtocurve (rfc9380) implemented (especially for ristretto255?)
- Assert failure observed on box_seal test HOT 1
- Intentional segfault never occurs in tests sodium_utils{23} HOT 7
- Random assert failure in onetimeauth test HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsodium.