enhancement to callbacks about vue-json-excel

[jecovier]

It's a great idea!... the only thing I don't like is the ALL condition, because it's an arbitrary string and lost the ability to reach nested properties... maybe, return the last object you reach with the field value or if field it's undefined return the complete object

[ljm42]

I don't think we lose access to nested properties, inside the callback you could just reference value.phone.mobile, right?

But I agree about "_ALL_". I like your idea of leaving the field undefined:

'Location': {
  callback: (value) => {
    return value.city + ", " + value.country;
  }
},

getValue() would just need a guard on the line that defines indexes:

getValue(key, item) {
  const field = typeof key === "object" ? key.field : key;
  let indexes = field ? field.split(".") : [];
  let value = this.defaultValue;

  if (!field)
	value = item;
  else if (indexes.length > 1)
	value = this.getValueFromNestedItem(item, indexes);
  else
	value = item[field];

  if (key.hasOwnProperty('callback'))
	value = this.getValueFromCallback(value, key.callback);

  return value;
},

[jecovier]

@ljm42 thanks for the code, It's added with a little change (interpreter problems ¬¬) but its functional now... documentation was added to README file. Thanks!

[ljm42]

Thanks! I like the way you explained it in the readme too

The mimetype has changed again though, can we change it back? Or make it an option somehow?

Also, in getValue(), I noticed that if you trigger this else statement:

 else
   value = item[field];

and don't have a callback, then parseValue() is never called on that value. Is that an issue?

[jecovier]

@ljm42 🤦‍♂️ sorry, I've changed it in my local, it won't change again... yeah! I add the parseValue, thanks!

[ljm42]

Sorry, the mimetype isn't quite right :)

This:
"vnd.ms-excel"
should be:
"application/vnd.ms-excel"

[ljm42]

do you disagree?

[jecovier]

🤦‍♂️ it's fixed now, thanks! 😃

[ljm42]

perfect, thanks!