Coder Social home page Coder Social logo

Comments (4)

jdryg avatar jdryg commented on May 23, 2024

Thanks for the report. Will take a look probably tomorrow. Yes, padding all commands to some predefined alignment should be the way to go.

from vg-renderer.

jdryg avatar jdryg commented on May 23, 2024

I just pushed some changes regarding this bug.

The only way I could reproduce the crash was with -s SAFE_HEAP=1. Without it, WebAssembly (-s WASM=1) worked without a problem (as it's supposed to since it supports unaligned accesses), and asm.js (i.e. no WASM flag) asserted here https://github.com/jdryg/vg-renderer/blob/master/src/vg.cpp#L4368
But none of them crashed as they do with SAFE_HEAP=1.

Either way, please test it and report back as soon as you find the time.

from vg-renderer.

jdryg avatar jdryg commented on May 23, 2024

@hugoam Any news on this one? Does it still happen with the latest version of the code?

from vg-renderer.

hugoam avatar hugoam commented on May 23, 2024

Hey ! I might have confused WASM and asmjs when reporting the issue, it might have happened in the asmjs build. But it doesn't happen anymore in either of my builds, so I think your solution is perfect :)

from vg-renderer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.