Renaming Cells with Ctrl-Enter produced ERROR about google-refine

[GoogleCodeExporter]

Original comment by thadguidry on 17 May 2010 at 6:43

• Added labels: ****
• Removed labels: ****

Attachments:

• phish_clean.gridworks.tar.gz

[GoogleCodeExporter]

Presumably fixed by r809, by sprinkling in a few "synchronized". Concurrency 
bugs are hard to test.

Original comment by [email protected] on 18 May 2010 at 12:03

• Changed state: Fixed
• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Ugh.  I'm not saying it's not fixed, but the "sprinkling" wording makes me 
profoundly 
uncomfortable.  The thing that makes our current antiquated concurrency models 
so 
difficult is that they require expert analysis.  "Sprinkling" may fix it or it 
just 
may just slow irrelevant operations down while not protecting the critical ones.

But perhaps I'm reading too much into the wording...

Original comment by tfmorris on 18 May 2010 at 1:46

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Not fixed.

Click Edit on cell "Dallas" and rename to "ticktock".
Then tap CTRL-ENTER and cells update.
Click Edit on different cell "Richardson" and rename to "yoyo".
Then tap CTRL-ENTER and cells update, but "Dallas" cells re-appear as well.

Original comment by thadguidry on 18 May 2010 at 2:08

• Changed state: Started
• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Tfmorris, excuse my language. I meant putting synchronized on public methods so 
to ensure that the object is 
always accessed in a coherent state.

Thad, that's a different issue that has to do with keystroke handling. 
Apparently somehow the Enter key is fired 
on the Undo link of the previous operation.

Original comment by [email protected] on 18 May 2010 at 2:26

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Fixed by r812.

Original comment by [email protected] on 18 May 2010 at 2:52

• Changed state: Fixed
• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Original comment by tfmorris on 18 Sep 2012 at 2:21

• Added labels: Milestone-2.0
• Removed labels: ****

[GoogleCodeExporter]

Original comment by tfmorris on 18 Sep 2012 at 2:56

• Added labels: Milestone-1.1
• Removed labels: Milestone-2.0