Coder Social home page Coder Social logo

Comments (6)

ccleaud avatar ccleaud commented on July 23, 2024

Not that easy to reproduce.
You can open a file, and select 1 word then play with CTRL+Q and see strange behaviors:

  1. other lins are commented
  2. text selection moves to the end of document

from 3p.

ccleaud avatar ccleaud commented on July 23, 2024

You're welcome to ask me to reproduce.

from 3p.

jcaillon avatar jcaillon commented on July 23, 2024

Ok,

I couldn't reproduce your bug once again, holding CTRL+Q after selecting all the text in a 44k lines document doesn't crash notepad++. However, the function runs slowly as it has to comment each 44k lines one by one....

The toggle comment feature now works differently :

  • if there is not selection, toggle on/off the current line
  • if there is a selection, toggle on/off the selected BLOCK
  • Now also works for multiple selections

I also added module to prevent the user from spamming a key.

Since i completely refactored the function, i'll consider this bug corrected.

Corrections included in v1.0.1

from 3p.

ccleaud avatar ccleaud commented on July 23, 2024

Let's talk about this trouble next tuesday morning while drinking coffee ^^

from 3p.

ccleaud avatar ccleaud commented on July 23, 2024

Please note it doesn't crash Notepad++, it only have trouble with text selection that causes more than selected lines to be commented / uncommented.

from 3p.

jcaillon avatar jcaillon commented on July 23, 2024

Oh, ok i see what you mean; Yeah the selection was wrongly expanded after adding /* and */, this is fixed now

from 3p.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.