Cannot delete rows from a temporal history table about respawn

[neelmallepally]

I would like to work on it and submit a PR if you think this is a valid issue.
Possible solution: Find if a table has a temporal table and set SYSTEM_VERSIONING = OFF for it. After delete, reset SYSTEM_VERSIONING = ON

Question: I primarily work with SQL Server. Does the solution have to be for all database types that this library supports?

[jbogard]

PR? I don't have a project using temporal tables.

What would the solution be here?

[jbogard]

Sounds good!

…

On Mon, Jan 22, 2018 at 3:33 PM, OpenWindow ***@***.***> wrote: I would like to work on it and submit a PR if you think this is a valid issue. Possible solution: Find if a table has a temporal table and set SYSTEM_VERSIONING = OFF for it. After delete, reset SYSTEM_VERSIONING = ON — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGYMqpoFmXdupmTAFcchj83TQS2Vlndks5tNP6XgaJpZM4RooRz> .

[jbogard]

And no, it doesn't have to work for all database types. But it sounds like for some databases, you'd want some way to query additional metadata (see #38 ) and perform custom actions based on that.

[dozmus]

@jbogard Any reason why this was not merged in? I am in need of this feature.

[jbogard]

@dozmus Check the PR, it has conflicts and unresolved feedback

[dozmus]

I'm happy to wrap this PR up if that's okay with you. I've locally fixed the merge conflicts, and have the tests passing.
Your comment about automatic detection was already fixed by the OP, are there any other concerns?

[dozmus]

@jbogard see #60