Bug in EC points addition about ecsol

[k06a]

Or I am using it the wrong way :)

[k06a]

Calling ec._ecAdd(x1,y1,1,x2,y2,1) instead of ec._jAdd(x1,y1,x2,y2) gives:

04
c59f3b7f761930f5d1b3c597bf30a130b3d95f53210e695a483005b793a0e04e
b6a58b4c2d65315959c5e8854ffcbea96102dc8313714dcc8b7b7aee12657d7f

This point is also NOT on y^2 = x^3 + 7 (mod m) curve.

[k06a]

Here is proof that arguments were passed correctly https://etherscan.io/address/0x28dcd428e8125990f9e5fe1b82db0e3ed240711c#readContract:

dec2hex(89386970493588142485774255413527382305899003391019828884855784683786446364750) =>
C59F3B7F761930F5D1B3C597BF30A130B3D95F53210E695A483005B793A0E04E

dec2hex(82613429604321748106126205559785003700251151848839269056902677945456773135743) =>
B6A58B4C2D65315959C5E8854FFCBEA96102DC8313714DCC8B7B7AEE12657D7F

[jbaylina]

The result gives a denominator that it's not one. If you do the inverse of the denomitator z and multiply by x and y you will see that it gives the right answer.

[k06a]

@jbaylina thanks!