Dynamic Faces difficult to impossible to use with custom UIViewRoot about jsf-extensions

[glassfishrobot]

Reported by kenpaulsen

[glassfishrobot]

@edburns said:
This is a dup of Ken's other issue.

• • • This issue has been marked as a duplicate of 35 ***

[glassfishrobot]

kenpaulsen said:
This is a different issue.

Issue 35 relates to using encodeAll(), which isn't available to JSF 1.1
ViewHandlers making those ViewHandlers incompatible with DynamicFaces.

This issue relates to the UIViewRoot. Other frameworks which also provide a
UIViewRoot must extend from DynamicFaces UIViewRoot... or it is impossible to
work with DynamicFaces. This issue asks that UIViewRoot functionality either be
implemented w/o subclassing, or that an interface be provided to more cleanly
integrate other frameworks with DynamicFaces.

I will reopen this issue.

Thanks!

Ken

[glassfishrobot]

@edburns said:
Created an attachment (id=10)
Fix for this bug, first iteration

[glassfishrobot]

@edburns said:
Fix checked in.

[glassfishrobot]

kenpaulsen said:
Reopening b/c changes were rolled back temporarily.

[glassfishrobot]

@edburns said:
Re-fixed this on the HEAD.

[glassfishrobot]

kenpaulsen said:
As currently written a UIViewRoot implemenation must also have the following
methods implemented with Dynamic Faces specific code:

• public Constructor();
• public void processDecodes(FacesContext context);
• public void processValidators(FacesContext context);
• public void processUpdates(FacesContext context);
• public boolean getRendersChildren();
• public void encodeBegin(FacesContext context) throws IOException;
• public void encodeChildren(FacesContext context) throws IOException;
• public void encodeEnd(FacesContext context) throws IOException;
• protected void broadcastEvents(FacesContext context, PhaseId phaseId);

This is in addition to the new interface methods defined:

• public void postExecuteCleanup(FacesContext context);
• public void encodePartialResponseBegin(FacesContext context) throws
  IOException;
• public void encodePartialResponseEnd(FacesContext context) throws IOException;

It is currently still very difficult to provide a different "Dynamic Faces
compatible" UIViewRoot without rewriting all the DF impl's functionality because:

• Dependencies on private methods (invokeCallbackOnSubtrees and
  cealnupAfterView)
• Dependencies on private classes (PhaseAwareContextCallback and
  EscapeCDATAWriter)
• Dependency on protected method (broadcastEvents)
• Requirement that ViewRoot be at the Root of a UIComponent tree, etc.

Instead of providing the implementation required in the UIViewRoot in a subclass
of the UIViewRoot, we should provide this implementation in a different "helper"
class that perform the work. The methods in this "helper" class would need to
accept the UIViewRoot (or perhaps, PartialTraversalViewRoot) on which to
operate. The default DF ViewRoot impl and other implementations could utilize
this helper class to more easily provide a functional DF implementation (and
make for more maintainable code).

Ken

[glassfishrobot]

kenpaulsen said:
I committed the proposed changes. The PartialTraversalViewRootHelper class now
exists to assist in creating PartialTraversalViewRoot implementations.

[glassfishrobot]

File: message.txt
Attached By: @edburns

[glassfishrobot]

Was assigned to jsf-extensions-issues

[glassfishrobot]

This issue was imported from java.net JIRA JSF_EXTENSIONS-36

[glassfishrobot]

Marked as fixed on Monday, February 26th 2007, 7:45:09 am