DynaFaces doesn't proprly escape CDATA sections about jsf-extensions

[glassfishrobot]

Reported by agoria

[glassfishrobot]

agoria said:
I propone a fix. Instead of:

writer.startElement("markup", comp);
writer.write("<![CDATA[");

// setup up a writer which will escape any CDATA sections
facesContext.setResponseWriter(new EscapeCDATAWriter(writer));

// do the default behavior...
comp.encodeAll(facesContext);

// revert the write and finish up
facesContext.setResponseWriter(writer);

writer.write("]]>");
writer.endElement("markup");

I would drop the EscapeCDATAWriter and use a StringWriter instead:

writer.startElement("markup", comp);
writer.write("<![CDATA[");

// setup up a writer which will escape any CDATA sections
StringWriter w = new StringWriter();
facesContext.setResponseWriter(writer.cloneWithWriter(w));

// do the default behavior...
comp.encodeAll(facesContext);

// revert the write and finish up
facesContext.setResponseWriter(writer);
writer.write(w.toString().replaceAll("]]>", "]]]]><![CDATA["));

writer.write("]]>");
writer.endElement("markup");

This seems to work.

[glassfishrobot]

@edburns said:
As far as I can tell, this one is fixed.

[glassfishrobot]

Was assigned to jsf-extensions-issues

[glassfishrobot]

This issue was imported from java.net JIRA JSF_EXTENSIONS-20

[glassfishrobot]

Marked as fixed on Wednesday, January 17th 2007, 3:06:45 am