Help getting latest version to work about json-schema-validator

[fge]

Hello,

Have you consulted the Javadoc links in the readme? Also, what do you call the latest version? 1.0.1 or 1.1.0? Don't forget that 1.1.0 is a development version.

In essence: load your schema and data the way you already do (using JsonLoader) and then do:

    final JsonSchemaFactory factory = new JsonSchemaFactory.Builder().build();
    final SchemaContainer container = factory.registerSchema(jsonSchemaNode);
    final JsonSchema schema = factory.createSchema(container);
    final ValidationReport report = schema.validate(jsonNode);
    return report.isSuccess();

[fge]

Also: JsonSchema is thread safe and immutable, so you can use only one instance to validate all your data. No need to rebuild a factory/schema each time, that's a waste of resources ;)

Please consult the javadoc links. There is sample code in them ;)

[fge]

Hello again,

Can I close the issue?

[java-developer]

Thank you for your help. For anyone having a similar issue, this is what I did:

/**
     * Returns <code>true</code> if the specified JSON conforms to the specified JSON schema.
     * 
     * @param json JSON to check.
     * @param jsonSchema JSON schema that the JSON must conform to.
     * @throws IOException If the JSON schema file cannot be opened.
     * @return <code>true</code> if the JSON is valid.
     */
    public boolean isValidJson(final String json, final File jsonSchema) throws IOException {
        final JsonSchemaFactory factory = new JsonSchemaFactory.Builder().build();
        final JsonNode jsonSchemaNode = JsonLoader.fromFile(jsonSchema);
        final SchemaContainer container = factory.registerSchema(jsonSchemaNode);
        final JsonSchema schema = factory.createSchema(container);
        final JsonNode jsonNode = JsonLoader.fromReader(new StringReader(json));
        final ValidationReport report = schema.validate(jsonNode);
        return report.isSuccess();
    }

[fge]

Hello,

You are wasting resources here. You create a factory each time, but it is thread safe: get it out of your method!

What's more:

• do you actually use several schemas? If not, you can get the JsonSchema instance out of the method as well;
• a factory can load from file URIs: you can do factory.getSchema("file:/path/to/your/file.json"), no need to create a File object.

As I said, there is a lot of Javadoc ;)

[java-developer]

Performance is not important here because this is just a utility method for my acceptance tests which validate the JSON output of my services. However, I have taken your advice and removed the factory from the method :)

I use several schemas so the JsonSchema instance needs to stay in the method.

I work for a big company and this method is being used by many people so I can't modify the method signature. As a result, I'll need to keep using File objects but I appreciate that your way is better.

[fge]

Thanks for your input :) You have just given me an idea: creating, say, a URIUtils class which takes various kinds of inputs and turns them into URIs. So, for instance:

URIUtils.toURI(fileObject)

will return an absolute URI of the form:

file:/path/to/the/backing/File/object

Similarly, I think I'll add a .fromString method to JsonLoader. I just didn't think someone would actually have String inputs! But it does not cost much to do.

Just out of curiosity, do you use another JSON library to begin with? I also have in the roadmap a generic way of injecting JSON data from other libraries (I use Jackson, as you'll have noticed), would that be of some interest to you?

It is to me, because I want to be able to inject from/output to MongoDB, and right now I do this by hand.

[java-developer]

We use Jackson annotations for marshalling via Spring 3.2 MVC using @responsebody on the controller methods.

Our requirements are very simple and I don't think we have any requirement to inject JSON data from other libraries. We just need to validate the output of our services against a JSON schema.

Thanks for taking the time to work on the project and answer questions :)