Coder Social home page Coder Social logo

Comments (5)

fge avatar fge commented on July 22, 2024

Hello,

Well, that is not exactly what I said ;) What I said is that I will probably not be using github's pull mechanism because it lacks a lot of features that I regularly use. You can therefore create a "normal" pull request and I'll merge it... Just not using github ;)

from json-schema-validator.

fge avatar fge commented on July 22, 2024

Hello,

As you may have seen, the code has changed quite a lot since you have opened this feature request. I have just fetched from your fork but don't see any of your work there.

Given the changes, it may be that you had problems with rebasing or whatever, but in any case, maybe you can just push whatever work you have done "in the past". If you have difficulties rebasing onto the current master branch, I can help with this.

Would you mind giving me an update?

from json-schema-validator.

fge avatar fge commented on July 22, 2024

Hello,

FWIW: I have added in my roadmap (see https://github.com/fge/json-schema-validator/wiki/Roadmap) the ability to have better error messages. My first idea for this is to internally store the validation error messages as JSON. For instance, for a given path in the instance (we already have that path thanks to ValidationReport's path field) a message could be:

{
    "phase": "instance validation",
    "keyword": "properties",
    "expected": [ "a", "b", "c" ],
    "actual": [ "a" ],
    "message": "required properties missing"
}

The existing .getMessages() method would then be the "serialization" of these as Strings, and you would also have other methods to access all validation messages.

The code is NOT started at all, this is just an idea. Comments?

from json-schema-validator.

fge avatar fge commented on July 22, 2024

OK well, since then I have implemented quite a lot of it ;) In fact, you cannot add plain strings to a validation report anymore.

Care to review what has been done? This is currently in master (it will not make it in 0.5, changes are too big for that). It is targeted for 0.6.

from json-schema-validator.

fge avatar fge commented on July 22, 2024

Closing this issue: the work is now done.

from json-schema-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.