Comments (6)
Good catch!
Just to be sure, can you give an example of a mail address which passes validation and should not pass it? Just for tests, and adding an appropriate comment in the code? I'd appreciate a lot!
from json-schema-validator.
Sure. while using 'new InternetAddress(instance.textValue())' the address 'testaddress123' passes as a valid address.
However, if we change this to 'new InternetAddress(instance.textValue(), true)', validation will fail as expected.
from json-schema-validator.
Hmmwait, RFC 822 does not specify anywhere that an email should have a domain part! As such, this "true" parameter does not really enforce RFC 822, just a "canonical" form for an email address.
As such, I do not see it as a bug. I know that 90+% people now think that "testaddress123" is not a valid email address -- in which they are mistaken.
The "workaround" is to:
{
"format": "email",
"pattern": "@"
}
since @ is not a valid character in a username part.
That is how I read the RFC. If an authoritative source on that tells otherwise, I'd like a link to it.
from json-schema-validator.
OK, since then I have reconsidered the matter at hand.
The problem you raise not only applies to the "email" format specifier, but also the "hostname" format specifier. In a similar vein, strictly speaking, "foo" is a valid hostname -- and email address.
However, I can only admit that most, if not all, use cases of JSON Schema will instinctively expect fully qualified hostnames and/or email addresses. I will therefore switch the default behaviour accordingly.
Expect a commit soon. And sorry for my bluntness ;)
from json-schema-validator.
Could you review the aforementioned commit? Tests have been adapted accordingly.
While this makes me uneasy wrt strict RFC conformance, you have me convinced that this will turn out to be the better choice.
from json-schema-validator.
Done.
from json-schema-validator.
Related Issues (20)
- Failed validation for no apparent reason?
- Getting java.util.concurrent.ExecutionException while validating
- Error when validating Json against a schema defining oneOf
- Are we planning on supporting draft-07 HOT 1
- Example code on README.md please plus links to examples in src
- Migrate from joda-time to java 8 time API HOT 2
- Improcess error hanling in getJsonSchema - never squash exceptions
- Android app crashes because schema (v4) cannot be found at runtime HOT 2
- Getting NPE when passing null to validate method.
- Has the functionality of the ResolvingSchemaWalker been replaced in more recent versions?
- Conflicting Transitive Dependency Versions for Guava and Jsr305
- Where is pom.xml ? I want to import this library to my local and customize it
- Not compatible with GraalVM
- NoSuchFieldError on signing
- When JSONObject contains JSONArray, JSONArray's object can not be validated
- draftv4/schema is different between json-schema-validator 2.2.14 and json-schema-core 1.2.14
- release new version HOT 2
- How can we get Error Message with the error path appended?
- Obtain JUST the message from a ValidationMessage?
- BUG: ECMA262 valid pattern throws an exception
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-schema-validator.