ISO-8601 DateTime formats about json-schema-validator

[fge]

OK, if we refer to this page:

http://en.wikipedia.org/wiki/ISO_8601

then the current code works as it should. HOWEVER, the draft also says that "Additional custom formats MAY be created".

This is worth investigating. The problem currently is that FormatKeywordValidator creates a one-shot static map of existing specifiers. In the short run, maybe a new format could be added, ie "date-time-ms" or something?

I'm open to ideas.

[csciuto]

You're right. Even though ISO-8601 supports many variants of date/time, the JSONSchema date-time specification only strongly recommends "SHOULD" supporting the version currently in place according to http://tools.ietf.org/html/draft-zyp-json-schema-03.

I need to re-think this on my end for a bit. I do like the idea of a built-in custom date format or two or three. If that doesn't get implemented, the only other option for me would be a regex to parse the date, which, while workable, isn't exactly elegant looking.

Thanks!

[csciuto]

csciuto@170a25e

Easy enough and solves my use-case quite elegantly since I can use the other "date-time" still when needed. What do you think?

[fge]

Yep, I'm ready to take that, except:

• change/add copyrights ;)
• I have just submitted a commit which changes FormatKeywordValidator to use an ImmutableMap, and added comments on top about supported keywords -- can you add a comment telling about this custom specifier?
• note to self: the pom.xml also needs to be updated with an entry for you -- I can do it, or you can do it, as you wish.

Thanks!

[csciuto]

Thanks!

• I've pulled your FormatKeywordValidator change into my fork, merged it, updated the javadoc, and am ready to push back.
• I added a Contributor section to the pom and put my name and email address in it.
• What do you want me to do with the copyrights?

[fge]

re: copyrights, you have modified FormatKeywordValidator, so your name should be in there as well -- that is what I meant. Same for your new validator etc.

I'll do this in a few hours' time. Thanks for your contributions!

[fge]

Done.