OAuthException throw not supporting in latest version, gettting app crash when throw error from UserRepository about ts-oauth2-server

[ankush-instinctiq]

`import { Service } from "typedi";
import { UserStatus, User } from "../entities/User";
import { AppDataSource } from "../config/data-source";
import {
ErrorType, ExtraAccessTokenFields,
GrantIdentifier, OAuthClient, OAuthException,
OAuthUser, OAuthUserIdentifier, OAuthUserRepository
} from "@jmondi/oauth2-server";
import { HttpStatus } from "../helper/response";

@service()
export class UserRepository implements OAuthUserRepository {
userRepository = AppDataSource.getRepository(User);

async getUserByCredentials(email: OAuthUserIdentifier, password?: string, grantType?: GrantIdentifier, client?: OAuthClient): Promise<OAuthUser | undefined> {
    const dbUser = await this.userRepository.findOne({
        where: { email: email?.toString() },
        relations: ['userRoleOrganizations', 'userRoleOrganizations.organization', 'userRoleOrganizations.role']
    });
    if (!dbUser) {
        throw new OAuthException("The username or password is incorrect!!", ErrorType.InvalidRequest, undefined, undefined, HttpStatus.BAD_REQUEST);
    }
    if (!await dbUser.verify(password)) {
        throw new OAuthException("The username or password is incorrect!!", ErrorType.InvalidRequest, undefined, undefined, HttpStatus.BAD_REQUEST);
    }
    if (dbUser.status != UserStatus.ACTIVE) {
        throw new OAuthException(`Your account is not active!!`, ErrorType.InvalidRequest, undefined, undefined, HttpStatus.BAD_REQUEST);
    }
    return dbUser;

}

}`

[jasonraimondi]

Any exceptions thrown from within the getUserByCredentials are being thrown. Nothing should be swallowing these errors.

https://github.com/jasonraimondi/ts-oauth2-server/blob/main/src/grants/auth_code.grant.ts#L76
https://github.com/jasonraimondi/ts-oauth2-server/blob/main/src/grants/auth_code.grant.ts#L308
https://github.com/jasonraimondi/ts-oauth2-server/blob/main/src/grants/password.grant.ts#L65

I'm going to need something more helpful in order to take action on this one.

[ankush-instinctiq]

Hi, i want to send my custom message in exception, like "The username or password is incorrect!!" or user is not active yet, so how we can catch custom exception message. it is working in your previous version OAuthException handled here. but in latest version not getting response of thrown exception. please help me.

…

On Thu, Aug 24, 2023 at 7:50 AM Jason Raimondi ***@***.***> wrote: Any exceptions thrown from within the getUserByCredentials are being thrown. Nothing should be swallowing these errors. https://github.com/jasonraimondi/ts-oauth2-server/blob/main/src/grants/auth_code.grant.ts#L76 https://github.com/jasonraimondi/ts-oauth2-server/blob/main/src/grants/auth_code.grant.ts#L308 https://github.com/jasonraimondi/ts-oauth2-server/blob/main/src/grants/password.grant.ts#L65 I'm going to need something more helpful in order to take action on this one. — Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BB3PRKWRY26GERMNJBY2W6TXW2273ANCNFSM6AAAAAA3ZPDFVE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jasonraimondi]

I will try to get this working in an example. If you're able to get an example up that would be helpful.

[jasonraimondi]

I've added an exception to the inMemoryUserRepository and it looks like it is throwing the correct exception, as expected.

https://github.com/jasonraimondi/ts-oauth2-server/compare/issues/82

You will need to create a replication of this for me so I can see the issue.

[ankush-instinctiq]

Hi, the has been resoved,
i just comments handleExpressError(error, res), and handle response,
it is working now,
thanks you.

const login = async (req: Request, res: Response) => {
try {
const oauthResponse = await authorizationServer.respondToAccessTokenRequest(req);
return handleExpressResponse(res, oauthResponse);
} catch (error) {
return responseStatus(res, HttpStatus.BAD_REQUEST, error.message, error);
// return handleExpressError(error, res);
}
}

router.route("/token").post(login);