Coder Social home page Coder Social logo

Comments (6)

JasonEtco avatar JasonEtco commented on August 24, 2024

Hey @EndBug, thanks for the suggestion! I don't fully understand - are you referring to the special command syntax that Actions uses? Would logging an error be equivalent to calling core.error()? If so - yeah, that makes sense, definitely something this library should just do magically. A PR would be great!

from actions-toolkit.

EndBug avatar EndBug commented on August 24, 2024

Yeah, that's exactly what I intended
Great, I'll open a PR as soon I'm ready 👍🏻

from actions-toolkit.

EndBug avatar EndBug commented on August 24, 2024

Hey @JasonEtco, I need an advice: I've developed this functionality, but the fact that GitHub already puts 'Error' and 'Warning' prefixes itself, doesn't it get redundant?

These are the current result from the @actions/core and signale:
@actions/core result
signale result

This is the current result with my version of actions-toolkit:
actions-toolkit result

I'm afraid that the signale prefixes are kind of redundant, and maybe it would be better to omit them when it's logging a GitHub command. (I also have an option to avoid logging to GitHub on a single log, and in that case they would be normal)

What do you think?

from actions-toolkit.

EndBug avatar EndBug commented on August 24, 2024

I'm just gonna go ahead and remove the redundant Signale prefix...

from actions-toolkit.

JasonEtco avatar JasonEtco commented on August 24, 2024

@EndBug awesome, I'll take a look there. Let's continue that conversation over in #137 - but I agree, the Actions UI has changed and now the Signale prefixes are redundant. It might even be worth removing Signale entirely in favor of a light abstraction that just uses core#warn/debug/error

from actions-toolkit.

github-actions avatar github-actions commented on August 24, 2024

This issue has been inactive for awhile; please comment if it's still relevant!

from actions-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.