Comments (6)
Hey @EndBug, thanks for the suggestion! I don't fully understand - are you referring to the special command syntax that Actions uses? Would logging an error be equivalent to calling core.error()
? If so - yeah, that makes sense, definitely something this library should just do magically. A PR would be great!
from actions-toolkit.
Yeah, that's exactly what I intended
Great, I'll open a PR as soon I'm ready 👍🏻
from actions-toolkit.
Hey @JasonEtco, I need an advice: I've developed this functionality, but the fact that GitHub already puts 'Error' and 'Warning' prefixes itself, doesn't it get redundant?
These are the current result from the @actions/core
and signale
:
This is the current result with my version of actions-toolkit
:
I'm afraid that the signale prefixes are kind of redundant, and maybe it would be better to omit them when it's logging a GitHub command. (I also have an option to avoid logging to GitHub on a single log, and in that case they would be normal)
What do you think?
from actions-toolkit.
I'm just gonna go ahead and remove the redundant Signale prefix...
from actions-toolkit.
@EndBug awesome, I'll take a look there. Let's continue that conversation over in #137 - but I agree, the Actions UI has changed and now the Signale prefixes are redundant. It might even be worth removing Signale entirely in favor of a light abstraction that just uses core#warn/debug/error
from actions-toolkit.
This issue has been inactive for awhile; please comment if it's still relevant!
from actions-toolkit.
Related Issues (20)
- Latest @octokit/rest has a .graphql method so no need to add it HOT 1
- Error regarding missing js-yaml dependency HOT 4
- File readme.md could not be found in your project's workspace HOT 2
- Can we set outputs ? HOT 2
- tolkit
- Specify some input or env that allows a user to override the default GITHUB_REPOSITORY env var HOT 4
- Support use with GitHub Enterprise servers HOT 3
- Stop warning about `HOME` not being present on Windows runners HOT 4
- Add a `secrets` option to the constructor HOT 3
- Not all feather icons are supported by actions HOT 7
- Debug mode HOT 1
- ✖ fatal HttpError: Bad credentials HOT 5
- minimist argument as string with space breaking HOT 13
- Specific events causes error logs HOT 5
- Creating a pull request review HOT 9
- Note about Architectural Context & Added Value HOT 2
- @octokit/graphql types HOT 3
- Ability to leverage graphql previews of the API is not advertised in README
- Logging Issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actions-toolkit.