Can't batch rename files which names start with dash '-' about nnn

[N-R-K]

how vigilant do you think we should be with this?

The fix looks simple. So there's no point in not doing the correct thing, IMO.

[KlzXS]

See #1820

[KlzXS]

Do they all have double dash options separator for the mv command?

-- as a marker for the end of options is a POSIX guideline, so it should be widely supported. Not to mention that it's been standard practice for many years. Of course, individual programs may not respect it, but mv most certainly will.

The same would go for cp and rm as well. And all the uses inside plugins. @jarun how vigilant do you think we should be with this? At least core nnn I'd say, but what about plugins?

[jarun]

Yes, please raise the PR. Also check for other places in the code where it may be an issue.

We should fix this in plugins too.

[Oxore]

I found that a similar functionality exists in the cpmv_rename function. It uses similar shell pipeline defined in patterns[P_CPMVRNM] that does not use the double dash separator (--) too, but it mvs and cpies files without a problem even if the name starts with a dash. This and the fact, that I don't fully understand neither of these two shell pipelines, takes away the last bit of any confidence I had to create a PR with the simple the double dash separator fix.

[KlzXS]

cpmv_rename() and batch_rename() (when dealing with selection) use absolute paths. You don't get this problem with absolute paths as the first character is by definition /.

So the fix is not strictly necessary in those cases, but it doesn't hurt them either. Just smack on a -- everywhere you see cp, mv or rm. Other shell programs might also benefit from the same treatment but leave those for now.

I don't fully understand neither of these two shell pipelines

Also, fair point. Those pipelines have zero documentation to their name other than "they do what they do". I should write something for that when I get some more time.