Comments (9)
http://linux.die.net/man/7/tcp
Apparently TCP_DEFER_ACCEPT
is not only not POSIX, but also not available in Linux before 2.4.
from googler.
OK. I'll release 2.5.1 shortly.
from googler.
Closed by mistake.
from googler.
I think we can safely assume either none or very small section of our users are on Linux 2.4. So I'll make this change for OS X only.
I am seeing more that 100 ms gain with this option enabled.
Can you please check if 99c1336 works for you?
from googler.
TCP_DEFER_ACCEPT
isn't the only problem. TCP_QUICKACK
is also not available, for instance.
I don't have time to read the code and figure out what each line does, but one should really stick to POSIX. If you want to have separate code for Linux then sure, it's your call; as I said I'll no longer work on new features and this is one, so it won't be my domain.
Here's tcp(4)
for you: https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man4/tcp.4.html.
from googler.
I don't have time to read the code
I wanted to know if the version is working for you. Not asking you to review the change.
it's your call
Yes, I intend to retain the optimizations for Linux given that both are available in the recent versions. Linux 2.4 was released in Jan 2001.
Commit 77fa658 has all these optimization options enabled only for Linux. Please confirm if this works on your system and I'll make the release.
from googler.
I wanted to know if the version is working for you
As said, no. Now it appears to be working.
from googler.
Linux 2.4 was released in Jan 2001.
Nowhere do we mention Linux before Jan 2001 is not supported. The usual way to feature test in python is try catch.
from googler.
Nowhere do we mention Linux before Jan 2001 is not supported.
I think we can keep arguing on this but it doesn't make practical sense. If someone comes back with reports on kernel 2.4 we'll provide a patch.
The usual way to feature test in python is try catch.
I didn't want to make extra calls when it's known to fail. I'll re-look at it later.
from googler.
Related Issues (20)
- Understanding packaging HOT 1
- 无法使用 HOT 1
- Googler doesn't use default browser HOT 1
- New Design for Google News HOT 9
- reCAPTCHA-solving to use the service HOT 2
- Can't see sitelinks? HOT 1
- DeprecationWarning: ssl.PROTOCOL_TLS is deprecated HOT 2
- How do I pipe the output? > HOT 1
- Search by filetype HOT 2
- How do I exclude specific keywords? HOT 1
- ssl.PROTOCOL_TLS is deprecated warning HOT 4
- No Results. HOT 4
- Video-specific search not working
- exception TrackedTextwrap: the impossible happened at offset nn of text "" HOT 2
- how we can include ads HOT 1
- Recent error message HOT 1
- googler skipping first result for some searchs HOT 3
- No results for domain search (when the site: keyword/-d switch in use) HOT 1
- Results site youtube.com (results order)
- Showing none or just a single result
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from googler.