Coder Social home page Coder Social logo

Comments (10)

schiller-manuel avatar schiller-manuel commented on June 2, 2024 1

BTW: could the "first" initial values be set using (useHydrateAtoms)[https://github.com/pmndrs/jotai/blob/main/src/react/utils/useHydrateAtoms.ts] and only subsequent changes to the initial value would be done through useEffect?

from form-atoms.

jaredLunde avatar jaredLunde commented on June 2, 2024 1

Hmm that's a reasonable case. I think I might have used useHydrateAtoms in an older version but the API didn't work with things like the the store.get(field.dirty) check. You cool to submit a PR?

from form-atoms.

jaredLunde avatar jaredLunde commented on June 2, 2024 1

Should the expected behavior for going from defined to undefined be that the value clears? It seems so, right? In that case the check would have to go

from form-atoms.

schiller-manuel avatar schiller-manuel commented on June 2, 2024 1

I played around with removing initialValue === undefined, turns out would cause issues if one uses useFieldInitialValue in combination with e.g. useInputField as the latter would issue a call to useFieldInitialValue with initialValue=undefined.

So we would need another value as a "reset" signal, how about RESET?

export function useFieldInitialValue<Value>(
  fieldAtom: FieldAtom<Value>,
  initialValue?: Value | typeof RESET,
  options?: UseAtomOptions
): UseFieldInitialValue {
  const field = useAtomValue(fieldAtom, options);
  const store = useStore(options);

  React.useEffect(() => {
    if (initialValue === undefined) {
      return;
    }
    if (!store.get(field.dirty)) {
      store.set(field.value, initialValue);
    }
    store.set(field._initialValue, initialValue);
  }, [store, field._initialValue, field.value, field.dirty, initialValue]);
}

from form-atoms.

jaredLunde avatar jaredLunde commented on June 2, 2024

what's the use case?

from form-atoms.

jaredLunde avatar jaredLunde commented on June 2, 2024

i think the biggest annoyance would be forcing people to use useMemo on their initial values (objects, arrays, etc) but i don't recall what other reason i had if there was one

from form-atoms.

schiller-manuel avatar schiller-manuel commented on June 2, 2024

I have an edit form where the data is loaded through react-query which uses an stale-while-revalidate caching strategy. This means the form is populated with possibly outdated data, then the data is reloaded in the background while the form is already mounted and then some fields' initial value may be updated.

from form-atoms.

schiller-manuel avatar schiller-manuel commented on June 2, 2024

do you think that equality check I added in the above code is necessary?

from form-atoms.

github-actions avatar github-actions commented on June 2, 2024

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from form-atoms.

MiroslavPetrik avatar MiroslavPetrik commented on June 2, 2024

@schiller-manuel I'm revisiting the hydration as the current hook fails to initialize the form when rendered on the server (Next.js)

BTW: could the "first" initial values be set using (useHydrateAtoms)[https://github.com/pmndrs/jotai/blob/main/src/react/utils/useHydrateAtoms.ts] and only subsequent changes to the initial value would be done through useEffect?

https://github.com/form-atoms/field/blob/main/src/hooks/use-hydrate-field/useHydrateField.ts

from form-atoms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.