Comments (4)
Another option is simply to drop pre-commit. I've been reluctant to adopt pre-commit because of its bias for repeatability over sustainability. I'm personally disinvested in pre-commit, and I don't use it personally in my workflows, but I'm okay with allowing it if it benefits others and adds negligible toil to the project(s). That is, an occasional PR in skeleton is fine.
I'm open to the other options too. I'd like to see any option implemented in a sustainable way (infrequent pull requests centralized in skeleton would be fine).
from skeleton.
@jaraco I saw that older Ruff (from pre-commit) started conflicting with the newer Ruff (from tox) when I worked on jaraco.classes
. What do you think about these options? Do you maybe have some other ideas?
from skeleton.
infrequent pull requests
You can configure it to run quarterly instead of weekly:
ci:
autoupdate_schedule: quarterly
https://pre-commit.ci/#configuration-autoupdate_schedule
(And as mentioned, another option is to use Renovate, but I don't think that can fix PRs. https://docs.renovatebot.com/modules/manager/pre-commit/)
from skeleton.
Concerning the pre-commit
tool as a whole. I personally only enjoy it for its CI autofixes. Which isn't even happening for skeleton-based projects (for various reasons Jason already mentioned). I also highly dislike blocking or slow local commit hooks.
It might be worth considering a GitHub action like https://github.com/EndBug/add-and-commit or https://github.com/stefanzweifel/git-auto-commit-action . I'm personally looking for something like this since I'm also hitting pre-commit limitations with dprint and eslint (on top of the version lock annoyance), but haven't yet tested or vetted any. At work I wrote our own Azure DevOps extension for it.
Edit: if the configs are being kept solely "to offer a git hook command for those that use it", maybe instead you could offer a tox env command to autofix everything and let the dev decide how they wanna add it as a git hook ? (manually, pre-commit tool, husky, etc.)
from skeleton.
Related Issues (20)
- Release not running for tagged commit. HOT 15
- Non-SCM-managed skeleton brainstorming
- 3.3.1: create temp directory in source tree causes build fail HOT 3
- Missing checks for cyclometric complexity and code style warnings
- Apply Scientific Python repo-review suggestions HOT 14
- History rendering without dates HOT 2
- Capture motivations for CI build matrix
- Enable strict and disable "ignore missing imports" where viable HOT 3
- `target-version` in `ruff.toml` HOT 5
- Move project metadata to pyproject.toml HOT 2
- Add a pre-commit hook to expand relative ticket refs to absolute HOT 1
- macOS failing on Python 3.8 HOT 5
- Extras for tests and docs should be 'test' and 'doc'
- tests failing when resources unavailable after building from Github tarball HOT 1
- The blog post is out-of-date
- What's the best URL for the GitHub repo? HOT 3
- Implement coverage aggregation HOT 1
- No need for `preview = true` in `ruff.toml` any more
- Difficulties in packaging HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skeleton.