Asynchronous datasets / datasets not supported anymore? Multiple chained asynchronous test dependencies about core

[thetutlage]

Please share the code you have a written and there is no version 4.0 for @japa/runner.

[Arteneko]

test.group('computeMovementSummary()', async () => {
  const counterparties = await Promise.all([
    'input',
    'pool',
    'output',
  ].map((type: CounterpartyType) => CounterpartiesFactory.merge({ type }).create()))
  const [input$$, pool$$, output$$] = counterparties;

  const movements: { origin: string; destination: string; amount: number; }[] = [
    { origin: pool$$.id, destination: output$$.id, amount: 1000 },
    { origin: input$$.id, destination: pool$$.id, amount: 1000 },
  ]

  test.group('with only one movement', () => {
    const summary = computeMovementSummary([movements[0]], counterparties)

    test('it should return the destination as pivot', (assert) => {
      assert.equal(summary.pivot.id, pool$$.id)
    })

    test('it should return the base amount', (assert) => {
      assert.equal(summary.amount, movements[0].amount)
    })
  })

  test.group('with multiple movements (case: a reimbursement)', () => {
    const summary = computeMovementSummary(movements, counterparties)

    test('it should return the first destination as pivot', (assert) => {
      assert.equal(summary.pivot.id, pool$$.id)
    })

    test('it should return a nil amount', (assert) => {
      assert.equal(summary.amount, 0)
    })
  })
})

This is the code "in natural implementation way", for the two examples, here's what I tried.

// Property 'with' does not exist on type 'RunnerTest'.ts(2339)
test('it should return the first destination as pivot', (assert, c) => {
  assert.equal(summary.pivot.id, c[1].id)
}).with(async () => await Promise.all([
    'input',
    'pool',
    'output',
  ].map((type: CounterpartyType) => CounterpartiesFactory.merge({ type }).create())))

// Expected 2 arguments, but got 1.ts(2554)
test('it should return the first destination as pivot')
.with(async () => await Promise.all([
    'input',
    'pool',
    'output',
  ].map((type: CounterpartyType) => CounterpartiesFactory.merge({ type }).create())))

[thetutlage]

What version of @japa/runner are you using?

[Arteneko]

I didn't have @japa/runner installed (since it wasn't mentioned in adonis' testing recipe), but after installing it, it's using the latest, so @japa/[email protected]

[thetutlage]

Then please follow the upgrade docs first. https://japa.dev/releases/version-5

[Arteneko]

That... could be useful to mention it on Adonis, at least as a content warning for an obsolete guide...

[thetutlage]

Agree. The cookbooks needs an updated. I will look into it :). Closing this issue for now