Error occurred: no implicit conversion of nil into String about vagrant-r10k

[cdenneen]

Same issue with 0.3.0:

/Users/cdenneen/.vagrant.d/gems/gems/vagrant-r10k-0.3.0/lib/vagrant-r10k/helpers.rb:107:in `join': no implicit conversion of nil into String (TypeError)
    from /Users/cdenneen/.vagrant.d/gems/gems/vagrant-r10k-0.3.0/lib/vagrant-r10k/helpers.rb:107:in `r10k_config'
    from /Users/cdenneen/.vagrant.d/gems/gems/vagrant-r10k-0.3.0/lib/vagrant-r10k/action/validate.rb:23:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/config_validate.rb:25:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/handle_box.rb:56:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in `block in run'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in `busy'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in `run'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/call.rb:53:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/check_virtualbox.rb:17:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in `block in run'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in `busy'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in `run'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:214:in `action_raw'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:191:in `block in action'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/environment.rb:516:in `lock'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:178:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:178:in `action'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run'

[cdenneen]

@jantman I know you fixed this similar error back in 0.2.0 but maybe it's back?

[trlinkin]

The issue come from this: https://github.com/jantman/vagrant-r10k/blob/master/lib/vagrant-r10k/helpers.rb#L107

With the changes made to the puppet apply provisioner in vagrant for Puppet 4, the manifest_file setting is optional now. However, this plugin hopes to find it set explicitly. I have not run down the options yet, but I'd imagine there is a way to grab the value after the explicitly provided settings are merged with the defaults so that this can always succeed.

The workaround for now is to explicitly specify the manifest_file and manifests_path settings. While this may be redundant, it will at least work.

[jantman]

Ah, ok. I actually haven't used this plugin with puppet4 yet.

@trlinkin thanks for spotting that and suggesting the workaround.

I'm going to need some time to dig into this and try to figure out the best fix, but I'm not sure I'll be able to get to it until tomorrow night.

@cdenneen If the workaround of explicitly specifying manifest_file and manifests_path doesn't work, ping me back and I'll see if I can find the time later tonight to start work on this.

[jantman]

Um... this looks like a bit of an oops on my part. r10k doesn't need to know about the manifest file. In fact, as far as I can tell, the :manifest_file value is only used in one place in all of my code... a log message.

[jantman]

@trlinkin @cdenneen I have a fix for this tested, and should be releasing it imminently soon as 0.4.1.

[jantman]

@trlinkin @cdenneen 0.4.1 is released and pushed to rubygems. Could someone please update the plugin and verify that things now work, without the workaround?

I've documented example puppet4 use in the readme: https://github.com/jantman/vagrant-r10k/blob/master/README.md#usage-with-puppet4-environment-based-provisioner