Coder Social home page Coder Social logo

Bump h3 version about timezonefinder HOT 6 OPEN

dylankbuckley avatar dylankbuckley commented on June 10, 2024 1
Bump h3 version

from timezonefinder.

Comments (6)

dylankbuckley avatar dylankbuckley commented on June 10, 2024 1

Yeah - I should have some time to work on this tomorrow.

from timezonefinder.

jannikmi avatar jannikmi commented on June 10, 2024 1

Please open another issue for python 3.12 compatibility. Let's see if there are other problems apart from the h3 related build errors. We can keep track of the progress there.

from timezonefinder.

jannikmi avatar jannikmi commented on June 10, 2024

Thanks for bringing this up.
It seems like v4 introduces a lot of breaking changes:

FAILED tests/shortcut_test.py::test_resolutions - AttributeError: module 'h3.api.numpy_int' has no attribute 'h3_get_resolution'
FAILED tests/shortcut_test.py::test_unique_pole_cells - AttributeError: module 'h3.api.numpy_int' has no attribute 'h3_get_resolution'

I think at the moment it is too early to force h3>=4
Would you be willing to raise a PR for supporting both v3 and v4 API?

from timezonefinder.

jannikmi avatar jannikmi commented on June 10, 2024

Great!
Ideally you could also add tests for both h3 versions (ensuring to test backward compatibility)

from timezonefinder.

Gui-FernandesBR avatar Gui-FernandesBR commented on June 10, 2024

Hey, I recently tried to install timezonefinder on python 3.12 but it is not working due to a wheel problem of h3 package.
I've opened up an issue in their repo (uber/h3-py#326), attaching here to follow-up.

Given the above error, the timezonefinder project cannot be built on Python 3.12 yet.
Shall we open another issue here to address people having the same installation problem on 3.12?

from timezonefinder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.