Coder Social home page Coder Social logo

Comments (2)

JangoSteve avatar JangoSteve commented on July 26, 2024

We're using a rack middleware to add our response processing to the rails response chain, which is the standard way of doing things like this. Doing a base.class_eval to rewrite the :render method definitely does not strike me as an entirely good idea (though I'm not much familiar with wiked_pdf, so I'm sure they have their reasons).

I would look to them to figure out what's going on, as their patching I guess is breaking any middleware that adds functionality to the rails responder.

from remotipart.

woodwardjd avatar woodwardjd commented on July 26, 2024

Per commentary, looks like the folks over in mileszs/wicked_pdf#111 agree their methodology could use some reconsideration. Thanks for looking into it!

from remotipart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.