Comments (3)
Interesting solution, but likely a better solution would be to pass in params as a reference, ie: _run_before_callbacks($type, &$params) this way each callback would add to the params reference rather than replace it. I've used this in similar situations with success.
Adding to params[key] causes issues with setting different keys in each instance. Ie: what happens when you run 5 callbacks how do you account for things?
from codeigniter-base-model.
Actually looking this closer passing &$params as a reference might eliminate the need to return $data at all. Since params would be modded without needing to return.
from codeigniter-base-model.
This problem has actually been fixed in the most recent version of the code - the callback / observer system has been rewritten to ensure it actually works as expected. Check out trigger()
from the latest version in the repo.
from codeigniter-base-model.
Related Issues (20)
- Clarification on Order By HOT 3
- not able to set OR condition for query. HOT 7
- Select specific fields HOT 4
- Get data from 2 tables joint in abother table HOT 7
- Custom "with()" method that has two joins, how to? HOT 8
- Observers not working HOT 2
- Validation not work HOT 1
- Call to a member function where() on null on Line: 895
- Three levels relationship HOT 5
- Multiple validation rules
- after_delete should also pass the original arguments
- Mandatory relationship HOT 1
- Validation and CI 3.0
- Temporarily disable soft delete? HOT 2
- Delete with where? HOT 1
- Where Dinamic Session
- How to relationship when id value has comma
- Order by Appending HOT 3
- $this->db->last_query() is always NULL HOT 1
- New maintainence HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codeigniter-base-model.