Coder Social home page Coder Social logo

Comments (3)

facultymatt avatar facultymatt commented on May 17, 2024

Interesting solution, but likely a better solution would be to pass in params as a reference, ie: _run_before_callbacks($type, &$params) this way each callback would add to the params reference rather than replace it. I've used this in similar situations with success.

Adding to params[key] causes issues with setting different keys in each instance. Ie: what happens when you run 5 callbacks how do you account for things?

from codeigniter-base-model.

facultymatt avatar facultymatt commented on May 17, 2024

Actually looking this closer passing &$params as a reference might eliminate the need to return $data at all. Since params would be modded without needing to return.

from codeigniter-base-model.

jamierumbelow avatar jamierumbelow commented on May 17, 2024

This problem has actually been fixed in the most recent version of the code - the callback / observer system has been rewritten to ensure it actually works as expected. Check out trigger() from the latest version in the repo.

from codeigniter-base-model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.