Suggestion: add call of trim() to this line about apex-dml-mocking

[jamessimone]

@derroman ah, interesting find! My apologies for not catching this, the repo has a slightly different version of Query than I use in prod but that’s my fault for not checking the quote wrapping for Ids. Your fix is a good one - I will incorporate it shortly!

[jamessimone]

@derroman this is now resolved. This was an interesting opportunity to delve into toString()'s base implementation - apparently, calling toString() on a Set adds spaces between the different entries; it's possible that the List class does this as well, but there it is obfuscated by an oddity singular to Set - it is an Iterable (you can use it in a for loop, after all), but it does not publicly show that. Most objects you can call instanceof to detect what they are, which is how the string parsing in the Query class works. However, from my previous work on this (as part of the Nebula Framework), I knew that Sets do not test true for being an Iterable, which is why they are handled separately to begin with.

Long story short - I shot myself in the foot by having a test involving Sets with multiple Ids ... but the Ids that I was using had the same value. I was able to easily reproduce your issue in the existing test that I have purely by updating the test to include a second unique Id. That was a tragic oversight on my part; it was fine to use the same Id for testing that Lists worked with this newer implementation, but of course the same value being added to a Set just reduces it to a single value.

Thanks for bringing this to my attention, and for using this framework!

[derroman]

But just for fun and because I did not find the time yet (a.k.a "too lazy to debug" ;-) ):

Why does this happen in the first place?

[derroman]

@jamessimone great and thanks for the interesting explanation!