Coder Social home page Coder Social logo

Comments (1)

jamesdolezal avatar jamesdolezal commented on June 3, 2024

Sara - overall very good implementations! I've gone through the branch and made some changes. Here's a quick rundown of the changes I made in my two commits on your branch:

Commit 8a6e33f:

  • Good work on this function! I mostly just added the ability to pass "None" as a destination option, which then allows the tiles to be extracted to the dataset's "tiles" directory as per project configuration

Commit 6a88b1d:

  • Nice regularizer function! I moved it from the sf.util module into the sf.model module, for organization reasons
  • Changed max_ and min_tiles_per_slide so that these criteria are applied to all TFRecords in the _interleave function
  • Improved readability on some function calls. When function calls start getting really long, it's best to split them onto multiple lines. E.g. model.py lines 623-628
  • Couple of code efficiency improvements. One example is lines 290-299; these could be condensed to just two lines (312 and 313)

I'll merge these changes into my dev branch shortly which has a number of other changes and improvements, but wanted a dedicated commit for your branch so you could see how I've implemented your code.

from slideflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.