Crash when calling TUIRibbon.SetRecentItems() about ribbonframework

[ghmrs356]

OK, I figured out that I can't call SetRecentItems() before OnLoaded has fired.

However, it still doesn't work (and crashes) because GetCommand returns nil for the recent items action. The action matches the Ribbon command name and it's definitely there (and in the RibbonManager) but TryGetCommand() for the recent element returns nil.

Any ideas why that is? The Recent command is set up in the Ribbon xml correctly.

[joachimmarder]

I will extend the TextPad sample to cover that case and see what's wrong.

[ghmrs356]

OK thanks! Some more info: I decided to fill the recent list dynamically like you do in the designer's preview. That works but the problem is that ribbon.GetSelectedRecentItem() also blows up because it uses the uninitialized fRecentItems as well. However, I managed to work around that by working my way to the selected recents item in the action event for the recentItemsAction (which is fired, so part of the system works) on foot:

cmd := uiribbonMain.Commands[RibbonMarkup.rcmdApplicationRecent];
if ((cmd <> nil) and (cmd is TUICommandRecentItems)) then begin
    recentItem := TUICommandRecentItemsActionLink(TUICommandRecentItems(cmd).ActionLink).Selected;
    [...]

Works and I don't mind maintaining the recent items dynamically. Might be worth investigating the issue though.

[joachimmarder]

fRecentItems is now assigned in TUIRibbon.DoCommandCreated() when TUICommandType.ctRecentItems is supplied.

Furthermore there is a new procedure TUIRibbon.AddToRecentItems(pPath: string);

[ghmrs356]

Thank you!